public inbox for [email protected]  

help / color / mirror / Atom feed

[pagdmin][patch] Update jasmine #3182
2+ messages / 2 participants
[nested] [flat]

* [pagdmin][patch] Update jasmine #3182
@ 2018-03-06 20:56 Joao De Almeida Pereira <[email protected]>
  2018-03-07 16:01 ` Re: [pagdmin][patch] Update jasmine #3182 Dave Page <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Joao De Almeida Pereira @ 2018-03-06 20:56 UTC (permalink / raw)
  To: pgadmin-hackers

Hi Hackers,

Attached you can find the patch that updates the version of jasmine to 3.0

Thanks
Joao


Attachments:

  [text/x-patch] upgrade-jasmine.diff (1.7K, 3-upgrade-jasmine.diff)
  download | inline diff:
diff --git a/web/package.json b/web/package.json
index 2707b334..a4cb58d5 100644
--- a/web/package.json
+++ b/web/package.json
@@ -18,7 +18,7 @@
     "file-loader": "^0.11.2",
     "image-webpack-loader": "^3.3.1",
     "is-docker": "^1.1.0",
-    "jasmine-core": "~2.9.0",
+    "jasmine-core": "~3.1.0",
     "jasmine-enzyme": "~4.1.1",
     "karma": "~1.5.0",
     "karma-babel-preprocessor": "^6.0.1",
diff --git a/web/regression/javascript/gettext_spec.js b/web/regression/javascript/gettext_spec.js
index 3e027450..2ad9d87c 100644
--- a/web/regression/javascript/gettext_spec.js
+++ b/web/regression/javascript/gettext_spec.js
@@ -13,7 +13,8 @@ import translations from 'translations';
 describe('translate', function () {
   describe('when there is no translation', function () {
     it('returns the original string', function () {
-      expect(gettext('something to be translated')).toEqual('something to be translated');
+      expect(gettext('something else to be translated')).toEqual('something' +
+        ' else to be translated');
     });
 
     describe('when there are substitutions', function () {
diff --git a/web/yarn.lock b/web/yarn.lock
index 666a20e6..5e310d79 100644
--- a/web/yarn.lock
+++ b/web/yarn.lock
@@ -4267,9 +4267,9 @@ isurl@^1.0.0-alpha5:
     has-to-string-tag-x "^1.2.0"
     is-object "^1.0.1"
 
-jasmine-core@~2.9.0:
-  version "2.9.1"
-  resolved "https://registry.yarnpkg.com/jasmine-core/-/jasmine-core-2.9.1.tgz#b6bbc1d8e65250d56f5888461705ebeeeb88f22f"
+jasmine-core@~3.1.0:
+  version "3.1.0"
+  resolved "https://registry.yarnpkg.com/jasmine-core/-/jasmine-core-3.1.0.tgz#a4785e135d5df65024dfc9224953df585bd2766c"
 
 jasmine-enzyme@~4.1.1:
   version "4.1.1"


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pagdmin][patch] Update jasmine #3182
  2018-03-06 20:56 [pagdmin][patch] Update jasmine #3182 Joao De Almeida Pereira <[email protected]>
@ 2018-03-07 16:01 ` Dave Page <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Dave Page @ 2018-03-07 16:01 UTC (permalink / raw)
  To: Joao De Almeida Pereira <[email protected]>; +Cc: pgadmin-hackers

Thanks, applied.

On Tue, Mar 6, 2018 at 8:56 PM, Joao De Almeida Pereira <
[email protected]> wrote:

> Hi Hackers,
>
> Attached you can find the patch that updates the version of jasmine to 3.0
>
> Thanks
> Joao
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2018-03-07 16:01 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-03-06 20:56 [pagdmin][patch] Update jasmine #3182 Joao De Almeida Pereira <[email protected]>
2018-03-07 16:01 ` Dave Page <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox