public inbox for [email protected]  

help / color / mirror / Atom feed

RM1492 [pgadmin4]
2+ messages / 2 participants
[nested] [flat]

* RM1492 [pgadmin4]
@ 2016-08-04 09:52  Harshal Dhumal <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Harshal Dhumal @ 2016-08-04 09:52 UTC (permalink / raw)
  To: pgadmin-hackers

Hi,

PFA patch for RM1492

Issue fixed: Generate proper queries for "View all/first 100/last 100 rows"
with table containing columns with capital letters.


-- 
*Harshal Dhumal*
*Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [text/x-patch] RM1492.patch (991B, 3-RM1492.patch)
  download | inline diff:
diff --git a/web/pgadmin/tools/sqleditor/command.py b/web/pgadmin/tools/sqleditor/command.py
index e491fba..de3a9f8 100644
--- a/web/pgadmin/tools/sqleditor/command.py
+++ b/web/pgadmin/tools/sqleditor/command.py
@@ -365,8 +365,8 @@ class TableCommand(GridCommand):
         """
         This function is used to fetch the primary key columns.
         """
-
-        manager = get_driver(PG_DEFAULT_DRIVER).connection_manager(self.sid)
+        driver = get_driver(PG_DEFAULT_DRIVER)
+        manager = driver.connection_manager(self.sid)
         conn = manager.connection(did=self.did, conn_id=self.conn_id)
 
         pk_names = ''
@@ -382,7 +382,7 @@ class TableCommand(GridCommand):
                 raise Exception(result)
 
             for row in result['rows']:
-                pk_names += row['attname'] + ','
+                pk_names += driver.qtIdent(conn, row['attname']) + ','
                 primary_keys[row['attname']] = row['typname']
 
             if pk_names != '':


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: RM1492 [pgadmin4]
@ 2016-08-04 10:55  Dave Page <[email protected]>
  parent: Harshal Dhumal <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Dave Page @ 2016-08-04 10:55 UTC (permalink / raw)
  To: Harshal Dhumal <[email protected]>; +Cc: pgadmin-hackers

Thanks, applied.

On Thu, Aug 4, 2016 at 10:52 AM, Harshal Dhumal
<[email protected]> wrote:
> Hi,
>
> PFA patch for RM1492
>
> Issue fixed: Generate proper queries for "View all/first 100/last 100 rows"
> with table containing columns with capital letters.
>
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2016-08-04 10:55 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-08-04 09:52 RM1492 [pgadmin4] Harshal Dhumal <[email protected]>
2016-08-04 10:55 ` Dave Page <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox