public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations
Date: Wed, 4 Apr 2018 10:05:16 +0100
Message-ID: <CA+OCxowPT=8t=QQb5VO2qDNP6Ss7ed3coPRH695oYwbFXJZb8Q@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELfk5FTn_eUb41C+BzUVbPKdcUCk0mB0rSJC2vfV9FV-Fg@mail.gmail.com>
References: <CAFOhELc-ST96E35Wcih=uXuXYe5ahnb4Qp+WWAYFPDBP1XTr=g@mail.gmail.com>
<CA+OCxow84Sigyn=2QQj4RKEV8ManXNqrg4kSmvhxgvbiFn8cpw@mail.gmail.com>
<CAFOhELc21et_BLjzrcro8_tk5-EDfHYP-cmuhST2s9wzR5o9ng@mail.gmail.com>
<CA+OCxoyp9smBhDexiWeCOcp4H8PAwnpkHnmg2ojZDtOSAFd=qw@mail.gmail.com>
<CAFOhELfXLBLuGM5stCZ3PTZhEeaYs9xwOPCAkb26hO8sAfL94A@mail.gmail.com>
<CA+OCxoxTJg==8RAH7ifXEKcZPomEA=i3uV-uhcWAsGayMSCQ8w@mail.gmail.com>
<CAFOhELfk5FTn_eUb41C+BzUVbPKdcUCk0mB0rSJC2vfV9FV-Fg@mail.gmail.com>
Thanks, applied.
On Wed, Apr 4, 2018 at 6:26 AM, Khushboo Vashi <
[email protected]> wrote:
> Hi Dave,
>
> On Tue, Apr 3, 2018 at 7:23 PM, Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> Thanks - I've committed this, however, could you send me an updated
>> screenshot for the docs? The one you sent was a different size and colour
>> depth from the others (and looked like a different scale).
>>
>> Please find the attached patch for the same.
>
>> On Tue, Apr 3, 2018 at 10:42 AM, Khushboo Vashi <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached updated patch.
>>>
>>> On Thu, Mar 29, 2018 at 6:54 PM, Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>> On Thu, Mar 29, 2018 at 1:51 PM, Khushboo Vashi <
>>>> [email protected]> wrote:
>>>>
>>>>>
>>>>>
>>>>> On Mon, Mar 26, 2018 at 6:07 PM, Dave Page <[email protected]> wrote:
>>>>>
>>>>>> Hi
>>>>>>
>>>>>> On Mon, Mar 26, 2018 at 7:23 AM, Khushboo Vashi <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> Please find the attached patch to fix RM #1978: Add an option to
>>>>>>> allow user to disable alertifyjs and acitree animations.
>>>>>>>
>>>>>>
>>>>>> I think these really need to be per-user settings, not
>>>>>> per-installation.. Whether or not animations are shown is really a matter
>>>>>> of personal taste and circumstance.
>>>>>>
>>>>>> Right, it should be per-user settings. Please find the attached
>>>>> updated patch.
>>>>>
>>>>
>>>> I found some issues I'm afraid:
>>>>
>>>> - The label "Enable dialogues/notifications animation?" should read
>>>> "Enable dialogue/notification animation?"
>>>>
>>>> Changed.
>>>
>>>> - Disabling treeview animation only seems to affect the main browser
>>>> treeview, and not others in the application (e.g. the one on the
>>>> Preferences panel).
>>>>
>>>> Fixed
>>>
>>>> - After disabling dialogue/notification animations, I cannot re-enable
>>>> notification animations. If I flip the switch back on, dialogue animations
>>>> immediately start working again, but notification animations don't even
>>>> work following a reload.
>>>>
>>>> Fixed.
>>>
>>>> Thanks.
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>> Thanks,
>>> Khushboo
>>>
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
> Thanks,
> Khushboo
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (12+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations
In-Reply-To: <CA+OCxowPT=8t=QQb5VO2qDNP6Ss7ed3coPRH695oYwbFXJZb8Q@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox