public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Surinder Kumar <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: RM#1462- AJAX request do not get fired second time
Date: Mon, 18 Jul 2016 09:50:57 +0100
Message-ID: <CA+OCxowTD3oWyjvAmUxahF9-aneWD67oL54LnwxOgwNVYrvLeA@mail.gmail.com> (raw)
In-Reply-To: <CAM5-9D880YxpQeQj7V1uWAP_bg8GNJiQ9vQf=fm0EziiCSW+rw@mail.gmail.com>
References: <CAM5-9D880YxpQeQj7V1uWAP_bg8GNJiQ9vQf=fm0EziiCSW+rw@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi

On Mon, Jul 18, 2016 at 8:34 AM, Surinder Kumar
<[email protected]> wrote:
> Hi
>
> Please find attached patch for the fix:
> Issue:
> This issue is regression of one of the flickering issue of RM#1242.
> "Aside from displaying/hiding the spinner, panes should have their content
> refreshed until and unless the new data differs from the previous, to reduce
> flicker"
>
> Solution:
> Along with caching the node node, we should also keep track of the previous
> node clicked.
> Fetch new data iff previous node and current node clicked differs.

This doesn't fix the issue for me. My test case:

1) Select the SQL tab
2) Click a schema, and the SQL is displayed.
3) Click Schemas, and "-- No SQL could be generated for the selected
object." is displayed.
4) Click the same schema as in step 2 again, and "-- No SQL could be
generated for the selected object." remains displayed.

Note that clicking any other schema in step 4 works fine.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch]: RM#1462- AJAX request do not get fired second time
  In-Reply-To: <CA+OCxowTD3oWyjvAmUxahF9-aneWD67oL54LnwxOgwNVYrvLeA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox