public inbox for [email protected]  
help / color / mirror / Atom feed
From: Dave Page <[email protected]>
To: Ashesh Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Murtuza Zabuawala <[email protected]>
Subject: Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn
Date: Thu, 15 Mar 2018 07:23:39 -0400
Message-ID: <CA+OCxowU18WyHVM5k5xUAU4V0kQkLNnVG8tk9e3-O6Vcu_d3aQ@mail.gmail.com> (raw)
In-Reply-To: <CAG7mmozECtBM6SrZ6pYLbUmH4HWN-quSa8dCiivADVW9tA+bBw@mail.gmail.com>
References: <[email protected]>
	<CAG7mmozECtBM6SrZ6pYLbUmH4HWN-quSa8dCiivADVW9tA+bBw@mail.gmail.com>

Hi

On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <[email protected]
> wrote:

> Hi,
>
> I have just noticed, we're ignoring migrations directory too.
> Should we not also check code styling for migrations directory?
>

Yeah, I was going to ask about that :-). Is there a specific reason why
we're ignoring the migrations Murtuza?


>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com;
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi;
>
> On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <[email protected]> wrote:
>
>> Ignore config_local.py and config_distro.py when running PEP-8 checks.
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>> f;h=53ae960aeba0dde6109b91c171f22758b1b04ebe
>>
>> Modified Files
>> --------------
>> web/.pycodestyle | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn
  In-Reply-To: <CA+OCxowU18WyHVM5k5xUAU4V0kQkLNnVG8tk9e3-O6Vcu_d3aQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox