public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Surinder Kumar <[email protected]>
Cc: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: PATCH: Python2.6 compatibility fixes (pgAdmin4)
Date: Fri, 9 Sep 2016 14:51:36 +0100
Message-ID: <CA+OCxow_PsOambXskeoejwT1rCNv-fQPOY-xFHStRLnbgp03+A@mail.gmail.com> (raw)
In-Reply-To: <CAM5-9D8HqnVfK6DTv=HXAmSNPq8iBP4x-57RAGQtk9juqncdWA@mail.gmail.com>
References: <CAKKotZSL4MNp21DUNrUBkh7u2CbhhPpqKhPHVcXjLgfWe-iycA@mail.gmail.com>
<CAKKotZRczSbfyQoezz9kgF3_FfCQ6i5vhbPUOface8i5U-axng@mail.gmail.com>
<CA+OCxoy0W9Lzj3G44u_eCcHRG8m2L3U0Y5FwZv+X5juuomASkA@mail.gmail.com>
<CAM5-9D8HqnVfK6DTv=HXAmSNPq8iBP4x-57RAGQtk9juqncdWA@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Thanks, applied.
On Fri, Sep 9, 2016 at 1:53 PM, Surinder Kumar
<[email protected]> wrote:
> Please find attached patch with following fix:
>
> 1) While running pgAdmin4 with latest git pull on Windows x64 environment, I
> got an exception on terminal console,
>>
>> NameError
>> NameError: global name 'arch_keys' is not defined
>
>
> Issue: arch_keys was defined inside the method add_server, but used outside
> the method.
>
> I have handled this issue in attached patch.
>
> On Tue, Sep 6, 2016 at 6:52 PM, Dave Page <[email protected]> wrote:
>>
>> Thanks, patch applied.
>>
>> On Tue, Sep 6, 2016 at 12:08 PM, Murtuza Zabuawala
>> <[email protected]> wrote:
>> > +++ Adding related RM.
>> >
>> > RM#1636 & RM#1659
>> >
>> > --
>> > Regards,
>> > Murtuza Zabuawala
>> > EnterpriseDB: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>> >
>> > On Tue, Sep 6, 2016 at 4:36 PM, Murtuza Zabuawala
>> > <[email protected]> wrote:
>> >>
>> >> Hi,
>> >>
>> >> PFA minor patch for Python2.6 compatibility with pgAdmin4.
>> >> Please review.
>> >>
>> >>
>> >> Regards,
>> >> Murtuza Zabuawala
>> >> EnterpriseDB: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list ([email protected])
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
view thread (5+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: PATCH: Python2.6 compatibility fixes (pgAdmin4)
In-Reply-To: <CA+OCxow_PsOambXskeoejwT1rCNv-fQPOY-xFHStRLnbgp03+A@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox