public inbox for [email protected]  

help / color / mirror / Atom feed
From: Dave Page <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][PATCH] To fix the issues with CSV file download
Date: Fri, 12 May 2017 10:38:32 +0100
Message-ID: <CA+OCxowbgwC5x_svRNv-z4hsxG8etGOXX2CnKiygKYPV8QFx4A@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZTYGyrnQrGFnsDqJuMqoSWEJdRMG6mv259rUPfWa21kiA@mail.gmail.com>
References: <CAKKotZS9mAg00K4YSP5PxLwDv5FJVrpNZwLTg4gabHpPkp4Lxg@mail.gmail.com>
	<CA+OCxoyW0oHHsn0xpJjhk3-QeiZBM_AcASoWxC1qPTwmwKPp+Q@mail.gmail.com>
	<CAKKotZTYGyrnQrGFnsDqJuMqoSWEJdRMG6mv259rUPfWa21kiA@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Thanks - patch applied.

On Thu, May 11, 2017 at 3:21 PM, Murtuza Zabuawala <
[email protected]> wrote:

> Hi Dave,
>
> Please find patch to handle non-ascii column names in CSV for Pyhton2.
>
> Thanks to Harshal for pointing out the issue.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Mon, May 8, 2017 at 6:06 PM, Dave Page <[email protected]> wrote:
>
>> Thanks, patch applied.
>>
>> On Mon, May 8, 2017 at 1:14 PM, Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> Please find the patch to fix the issues in CSV file download feature,
>>>
>>> 1) To handle non-ascii filenames which we set from table name
>>> RM#2314
>>>
>>> 2) To handle non-ascii query data
>>> RM#2353
>>>
>>> 3) To dump JSON type columns properly in csv
>>> RM#2360
>>>
>>> Please review.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list ([email protected])
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


view thread (4+ messages)

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][PATCH] To fix the issues with CSV file download
  In-Reply-To: <CA+OCxowbgwC5x_svRNv-z4hsxG8etGOXX2CnKiygKYPV8QFx4A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox