public inbox for [email protected]  
help / color / mirror / Atom feed
From: Dave Page <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4] [Patch] Implementation of the Data Grid and Query Tool
Date: Fri, 8 Apr 2016 10:02:40 +0100
Message-ID: <CA+OCxowdBvsnin91F2chyWLaH1ivEZmD_N_oY2DEJ11jEe3OjQ@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDcxkQ+T8XwpVabDo2=E5P0x3e27Gz4Ob3NAsi_9C=m14w@mail.gmail.com>
References: <CANxoLDe8fRZ=m8NGPc0=YQLS0vTc4-L5xmjyn2J2V1jUt937Mg@mail.gmail.com>
	<CA+OCxoz4ejTML6cjwMvOLd7vg4Dcd1koz30StnH_huND61gdzg@mail.gmail.com>
	<CANxoLDemUxkGL_z6=OPkA=3E-+ZDDmA3oht2wgDoCmurVv3JYQ@mail.gmail.com>
	<CA+OCxoxOOW4j0o+_NsV7JoW+-3aQ_As_xC90U3ShGw_DgWgLvQ@mail.gmail.com>
	<CANxoLDcp=sjd=P8U7qUP3tOQThAXDx+GUFyoE6F9xNDKwa5MnA@mail.gmail.com>
	<CA+OCxozK661Ha4RD51FtxmEdTzBd2h0nVgemAhfh0opbYOTerA@mail.gmail.com>
	<CANxoLDcxkQ+T8XwpVabDo2=E5P0x3e27Gz4Ob3NAsi_9C=m14w@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

On Fri, Apr 8, 2016 at 7:43 AM, Akshay Joshi <[email protected]>
wrote:
>
>
>>>>>> - The Query Tool menu icon should be a glyphicon, to match the others.
>>>>>>
>>>>>
>>>>>    There is no glyphicon available which match the Query Tool icon. I
>>>>> have found one like below which is "database-search" or can you please
>>>>> suggest some other icon.
>>>>>        [image: Inline image 1]
>>>>>
>>>>
>>>> That one looks perfect.
>>>>
>>>
>            We can't use this icon because it's not come with Bootstrap , I
> have picked this from "http://glyphicons.com/"; and I am not sure we can
> use it as per the Licence.
>

At the risk of annoying everyone immensely, on reflection I'm thinking we
should use Font Awesome as our default generic icons, and fall back to
Bootstrap's Glyphicons. I really hadn't realised how much larger the FA set
is.

For this particular issue, could we use FA's stacking? e.g. something like:
https://jsfiddle.net/pa8x6nt3/

If not, how about using the execute icon we discussed, e.g. fa-bolt?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Attachments:

  [image/png] image.png (2.4K, 3-image.png)
  download | view image

view thread (18+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4] [Patch] Implementation of the Data Grid and Query Tool
  In-Reply-To: <CA+OCxowdBvsnin91F2chyWLaH1ivEZmD_N_oY2DEJ11jEe3OjQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox