public inbox for [email protected]  
help / color / mirror / Atom feed
From: Dave Page <[email protected]>
To: Максим Кольцов <[email protected]>
Cc: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch] Remake Docker container packaging
Date: Wed, 4 Apr 2018 16:22:07 +0100
Message-ID: <CA+OCxowjOAPqmb8rzb+b5pCU9weN7+FV4DcrSRG-uBQ-6joCBA@mail.gmail.com> (raw)
In-Reply-To: <CAB_Kkxwx76Zrh_Uwuz1ckM2-s=744TG6JttKhtgkZ=aOYB-KjQ@mail.gmail.com>
References: <CAB_Kkxwp6rsiWEW4vJm_02zcckbvpb+x74NhF5HqfTLVCdVzpQ@mail.gmail.com>
	<CAKKotZSskdx7PXnpjH2TArqVYNxeurrURvfkWuVAm6ruP359AA@mail.gmail.com>
	<CAB_KkxyyNaLGcibge_1x5XpM6MJ6aOkd=_jUK6wMaRH6kLscAw@mail.gmail.com>
	<CAB_KkxwFVfgP22=SmN9uS2_LV+fUpByLAhBdh7yMv_SunmTe9g@mail.gmail.com>
	<CA+OCxowTycZFp4gGgwfKnWKCgkghQPhMy2xVWGfg=hjG=xJmgg@mail.gmail.com>
	<CAB_KkxyStp1+q7LoANtDD1yfxz8x+1BZQ=vTsJVo_E7m1afw8Q@mail.gmail.com>
	<CA+OCxoyB3oeC+VqEr85gPyuDnGYT23_e5++vUjaUFDzUYoYwbw@mail.gmail.com>
	<CAB_Kkxwx76Zrh_Uwuz1ckM2-s=744TG6JttKhtgkZ=aOYB-KjQ@mail.gmail.com>

Hi

On Wed, Apr 4, 2018 at 2:46 PM, Максим Кольцов <[email protected]> wrote:

>
> So, I've fixed it. Patch attached. Now whole requirements.txt is
> installed in one step, with no left-overs and incompabilities.


I've committed the patch with some minor changes to avoid breaking
compatibility with the older version:

- The default ports are 80/443 again.
- Username/password are set with PGADMIN_DEFAULT_EMAIL
and PGADMIN_DEFAULT_PASSWORD (though, I have left them without defaults).

Thanks!

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


view thread (12+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch] Remake Docker container packaging
  In-Reply-To: <CA+OCxowjOAPqmb8rzb+b5pCU9weN7+FV4DcrSRG-uBQ-6joCBA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox