public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM3371] Ping endpoint still send a pg4a_session cookie
Date: Mon, 2 Jul 2018 15:59:17 +0100
Message-ID: <CA+OCxownog76MyFfquLY7na_i9LtY4-h2FX6duJos1fKwAPMRg@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_=9x+L5S7OUGreVu-je9ADJPJv37uQ5UWqCYtGPw=5G6w@mail.gmail.com>
References: <CAM9w-_=9x+L5S7OUGreVu-je9ADJPJv37uQ5UWqCYtGPw=5G6w@mail.gmail.com>

Hi

I'm not in a position to test at the moment, but can you confirm this will
work if the root of pgAdmin is at (for example) /pgadmin? So the actual
root is /pgadmin/misc/ping ?

On Mon, Jul 2, 2018 at 1:35 PM, Aditya Toshniwal <
[email protected]> wrote:

> Hi Hackers,
>
> Attached is the patch for fixing RM3371 where /misc/ping service generate
> session file for each call and so cannot be used frequently.
> The patch is to skip session file generation and session caching for the
> URLs provided in SESSION_SKIP_PATH list config parameter.
> pg4a_session_cookie value will still be generated but nothing will be
> stored at the backend.
> Also, I have separated the garbage collection code in current ping service
> to a new url /misc/cleanup. /misc/ping will be purely for is alive check.
>
> Request you to kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][RM3371] Ping endpoint still send a pg4a_session cookie
  In-Reply-To: <CA+OCxownog76MyFfquLY7na_i9LtY4-h2FX6duJos1fKwAPMRg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox