public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Paresh More <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Sandeep Thakkar <[email protected]>
Cc: Hamid Quddus <[email protected]>
Subject: Re: PATCH: pgAdmin4 debian installer
Date: Mon, 9 May 2016 14:15:24 +0100
Message-ID: <CA+OCxowoNX9x7KLV7qUe2UeQMHFS8UodX-2erCejBXROqvOWnA@mail.gmail.com> (raw)
In-Reply-To: <CAAgiCNGZe7EXGsFBsLFg1Mu0QcUSJNHB3dz3CJZEzP2iE15n0Q@mail.gmail.com>
References: <CAAgiCNGZe7EXGsFBsLFg1Mu0QcUSJNHB3dz3CJZEzP2iE15n0Q@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi
Please see my earlier comments regarding the RPM packages - many of them
apply to this patch as well:
http://www.postgresql.org/message-id/[email protected]....
By way of additional comment, why does pkg/deb/README include a bunch of
boiler-plate text that I wrote long ago for the top-level README? It's out
of date now, and shouldn't be in a packaging README anyway.
Thanks.
On Tue, Apr 26, 2016 at 4:20 PM, Paresh More <[email protected]>
wrote:
> Hi Team, Dave,
>
> debian package is located @ location
>
> pgadmin4-web
>
> https://uploads.enterprisedb.com/download.php?file=0196f693811b57088da5ed7396cec284
>
> pgadmin4-runtime
>
> https://uploads.enterprisedb.com/download.php?file=958528f7c619efa7b483a6d2e0c23cd5
>
> Attached herewith are two patches.
>
> pgadmin4_debian.patch - This is the main patch that includes
> Makefile,README,debian scripts
>
> It will create two .deb i.e pgadmin4-runtime and pgadmin4-web.
> The pgadmin4-runtime depends on web and the web debian depends on the
> python packages.
> I have listed some packages which are not available on some systems so
> that Devrim can build them.
>
> The installation path for pgadmin4 is "/usr/pgadmin4/<major>.<minor>" and
> pgadmin4-web is the site-packages/pgadmin4-web
>
> As per rpm patch (*sandeep mentioned*) below is the comment which applies
> same for debian.
>
> *pgadmin4-server-ini.patch* - This is the patch for runtime/Server.cpp.
> As said pgadmin4-web and runtime installation directories are different and
> that means web does not exists in parallel to runtime like in sources.
>
> *Sandeep comments*
>
> *“I observed that the location of application settings was not defined in*
> *Server.cpp. As per QSettings doc, the default location on Unix is the*
> *$HOME/.config/<companyname>/<appname>.conf. Here, $HOME depends on the
> user*
> *that runs the application. So, I thought why not to define the
> application*
> *settings in application directory itself. RPM then knows where to define*
> *the ApplicationPath. I tested it and it worked fine with me. I haven't
> done*
> *this change for platform dependent*
>
> *Another change that I did in this file is that, I observed that
> canonicalPath()*
> *was not giving the absolute path (by removing the sym link and the*
> *redundant ".." as per doc). Hence, I used absolutePath() for the paths[i]*
> *that are relative (../web, etc) and not for the already absolute path
> (ex.*
> *ApplicationPath like /usr/lib/python2.7/site-packages/pgadmin4-web)”*
>
> What the patch will create ?
> - It would create deb folder in pkg
> - It would create Makefile, README and debian scripts
>
>
> --
>
> Thanks & Regards
>
> *Paresh More*
>
> [image: NEW-EDB-logo-4c]
>
> Pune, India.
> Cell : +919922000564 | www.enterprisedb.com
>
--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
view thread (4+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: PATCH: pgAdmin4 debian installer
In-Reply-To: <CA+OCxowoNX9x7KLV7qUe2UeQMHFS8UodX-2erCejBXROqvOWnA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox