public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list
4+ messages / 2 participants
[nested] [flat]
* [pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list
@ 2019-05-20 07:01 Murtuza Zabuawala <[email protected]>
2019-05-20 09:02 ` Re: [pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list Dave Page <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Murtuza Zabuawala @ 2019-05-20 07:01 UTC (permalink / raw)
To: pgadmin-hackers
Hi,
PFA minor patch to fix the issue with Backgrid PasswordCell.
In the Backgrid PasswordCell, The browser's autocomplete functionality
opens up the saved password list which cause the Backgrid to lose focus
from the current cell and causes issue in keyboard navigation.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachments:
[application/octet-stream] RM_4278.diff (432B, 3-RM_4278.diff)
download | inline diff:
diff --git a/web/pgadmin/static/js/backgrid.pgadmin.js b/web/pgadmin/static/js/backgrid.pgadmin.js
index 804dc92d..c8046093 100644
--- a/web/pgadmin/static/js/backgrid.pgadmin.js
+++ b/web/pgadmin/static/js/backgrid.pgadmin.js
@@ -1256,6 +1256,7 @@ define([
editor: Backgrid.InputCellEditor.extend({
attributes: {
type: 'password',
+ autocomplete: 'new-password',
},
render: function() {
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list
2019-05-20 07:01 [pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list Murtuza Zabuawala <[email protected]>
@ 2019-05-20 09:02 ` Dave Page <[email protected]>
2019-05-20 10:53 ` Re: [pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list Murtuza Zabuawala <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Dave Page @ 2019-05-20 09:02 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers
Hi
On Mon, May 20, 2019 at 8:01 AM Murtuza Zabuawala <
[email protected]> wrote:
> Hi,
>
> PFA minor patch to fix the issue with Backgrid PasswordCell.
> In the Backgrid PasswordCell, The browser's autocomplete functionality
> opens up the saved password list which cause the Backgrid to lose focus
> from the current cell and causes issue in keyboard navigation.
>
This is a much bigger issue - please see the previous discussion at
https://www.postgresql.org/message-id/flat/CAFOhELfwsvHDr-jE9V3xZnZugf2LF%2BRbmELxCO2NcrTqYmeS_Q%40m...
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list
2019-05-20 07:01 [pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list Murtuza Zabuawala <[email protected]>
2019-05-20 09:02 ` Re: [pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list Dave Page <[email protected]>
@ 2019-05-20 10:53 ` Murtuza Zabuawala <[email protected]>
2019-05-20 12:35 ` Re: [pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list Dave Page <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Murtuza Zabuawala @ 2019-05-20 10:53 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
Hi Dave,
Yes, that's is annoying for me too to debug that issue :)
And now setting it "new-password" does not cause the Backgrid to lose
focus, As of now I can see the only workaround that worked for me in all
browsers, I've tested in latest Chrome/FF & IE11.
On Mon, May 20, 2019 at 2:32 PM Dave Page <[email protected]> wrote:
> Hi
>
> On Mon, May 20, 2019 at 8:01 AM Murtuza Zabuawala <
> [email protected]> wrote:
>
>> Hi,
>>
>> PFA minor patch to fix the issue with Backgrid PasswordCell.
>> In the Backgrid PasswordCell, The browser's autocomplete functionality
>> opens up the saved password list which cause the Backgrid to lose focus
>> from the current cell and causes issue in keyboard navigation.
>>
>
> This is a much bigger issue - please see the previous discussion at
> https://www.postgresql.org/message-id/flat/CAFOhELfwsvHDr-jE9V3xZnZugf2LF%2BRbmELxCO2NcrTqYmeS_Q%40m...
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list
2019-05-20 07:01 [pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list Murtuza Zabuawala <[email protected]>
2019-05-20 09:02 ` Re: [pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list Dave Page <[email protected]>
2019-05-20 10:53 ` Re: [pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list Murtuza Zabuawala <[email protected]>
@ 2019-05-20 12:35 ` Dave Page <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: Dave Page @ 2019-05-20 12:35 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers
Hi
OK, well this won't hurt anyway, so patch applied.
Thanks!
On Mon, May 20, 2019 at 11:53 AM Murtuza Zabuawala <
[email protected]> wrote:
> Hi Dave,
>
> Yes, that's is annoying for me too to debug that issue :)
>
> And now setting it "new-password" does not cause the Backgrid to lose
> focus, As of now I can see the only workaround that worked for me in all
> browsers, I've tested in latest Chrome/FF & IE11.
>
>
>
>
> On Mon, May 20, 2019 at 2:32 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Mon, May 20, 2019 at 8:01 AM Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> PFA minor patch to fix the issue with Backgrid PasswordCell.
>>> In the Backgrid PasswordCell, The browser's autocomplete functionality
>>> opens up the saved password list which cause the Backgrid to lose focus
>>> from the current cell and causes issue in keyboard navigation.
>>>
>>
>> This is a much bigger issue - please see the previous discussion at
>> https://www.postgresql.org/message-id/flat/CAFOhELfwsvHDr-jE9V3xZnZugf2LF%2BRbmELxCO2NcrTqYmeS_Q%40m...
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2019-05-20 12:35 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-05-20 07:01 [pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list Murtuza Zabuawala <[email protected]>
2019-05-20 09:02 ` Dave Page <[email protected]>
2019-05-20 10:53 ` Murtuza Zabuawala <[email protected]>
2019-05-20 12:35 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox