public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE support for functions missing
Date: Fri, 3 Feb 2017 13:32:11 +0000
Message-ID: <CA+OCxowrguJS2U8hDSg88VJdirRkdVg4OCMWESypMbeJmXz_DA@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDeAD3VPenh7BCxtBWyZfcOD3LhA1bbOqc5xZ3foFxkshg@mail.gmail.com>
References: <CAFOhELdtSDCcHTs+LJukGH5E_xUYfm0JJLwpKrq+SfLqcWthKg@mail.gmail.com>
<CANxoLDeAD3VPenh7BCxtBWyZfcOD3LhA1bbOqc5xZ3foFxkshg@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
I doubt the order matters, but feel free to change it if it bugs you :-)
On Fri, Feb 3, 2017 at 12:54 PM, Akshay Joshi <[email protected]
> wrote:
> Hi Dave
>
> I have reviewed the patch and after applying it output in pgAdmin4
>
> CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2
> geometry)
> RETURNS boolean
> LANGUAGE 'sql'
> COST 100.0
> *IMMUTABLE NOT LEAKPROOF *
> * PARALLEL SAFE*
> AS $function$
> SELECT $1 OPERATOR(public.&&) $2 AND public._ST_Intersects($1,$2)
> $function$;
>
> but as per psql it should be
>
> CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2
> geometry)
>
> RETURNS boolean
>
> LANGUAGE sql
>
> *IMMUTABLE PARALLEL SAFE*
>
> AS $function$SELECT $1 OPERATOR(public.&&) $2 AND
> public._ST_Intersects($1,$2)$function$
>
>
> is this behaviour correct??
>
>
>
> On Fri, Feb 3, 2017 at 5:31 PM, Khushboo Vashi <
> [email protected]> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix RM 2089 : PARALLEL SAFE support for
>> functions missing.
>>
>> Fix: Incorporated the PARALLEL SAFE support for the functions and
>> procedures for PostgreSQL 9.6.
>>
>> Thanks,
>> Khushboo
>>
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list ([email protected])
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246
> <+91%2097678%2088246>*
>
--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
view thread (9+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE support for functions missing
In-Reply-To: <CA+OCxowrguJS2U8hDSg88VJdirRkdVg4OCMWESypMbeJmXz_DA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox