public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin][Patch]: Fixed RM 1467
2+ messages / 2 participants
[nested] [flat]
* [pgAdmin][Patch]: Fixed RM 1467
@ 2016-08-04 11:21 Khushboo Vashi <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Khushboo Vashi @ 2016-08-04 11:21 UTC (permalink / raw)
To: pgadmin-hackers
Hi,
Please find the attached patch for the fix of RM 1467: Unable to drop
trigger function, function and procedures.
The issue was produced because of execute_2darray function change.
Thanks,
Khushboo
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[text/x-patch] RM_1467.patch (1.6K, 3-RM_1467.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py
index 810bb49..ca69cac 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py
@@ -799,13 +799,11 @@ class FunctionView(PGChildNodeView, DataTypeReader):
)
)
- name, func_args, nspname = res['rows'][0]
-
SQL = render_template("/".join([self.sql_template_path,
'delete.sql']),
- name=name,
- func_args=func_args,
- nspname=nspname,
+ name=res['rows'][0]['name'],
+ func_args=res['rows'][0]['func_args'],
+ nspname=res['rows'][0]['nspname'],
cascade=cascade)
status, res = self.conn.execute_scalar(SQL)
if not status:
@@ -1327,7 +1325,8 @@ It may have been removed by another user or moved to another schema.
if not status:
return internal_server_error(errormsg=res)
- func_def, name = res['rows'][0]
+ func_def = res['rows'][0]['func_def']
+ name = res['rows'][0]['name']
# Fetch only arguments
argString = name[name.rfind('('):].strip('(').strip(')')
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgAdmin][Patch]: Fixed RM 1467
@ 2016-08-04 14:36 Dave Page <[email protected]>
parent: Khushboo Vashi <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Dave Page @ 2016-08-04 14:36 UTC (permalink / raw)
To: Khushboo Vashi <[email protected]>; +Cc: pgadmin-hackers
Thanks, applied.
On Thu, Aug 4, 2016 at 12:21 PM, Khushboo Vashi
<[email protected]> wrote:
> Hi,
>
> Please find the attached patch for the fix of RM 1467: Unable to drop
> trigger function, function and procedures.
>
> The issue was produced because of execute_2darray function change.
>
> Thanks,
> Khushboo
>
>
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2016-08-04 14:36 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-08-04 11:21 [pgAdmin][Patch]: Fixed RM 1467 Khushboo Vashi <[email protected]>
2016-08-04 14:36 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox