public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgadmin4][Patch]: RM #3122 - Backup not working on certificate (SSL) protected servers
Date: Wed, 14 Mar 2018 17:51:53 -0400
Message-ID: <CA+OCxowueZFqvC96m7XJGrmSvjdXJ6jQOgP32QZ+JaUu+XdzxA@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELezjboyr3SHAdazh1mmcTmNhH8XA6nig97CVpjCuNvEMw@mail.gmail.com>
References: <CAFOhELd49WZXE1DRNJuSo-Xfkvg7kXf7JUuAcNti=7BbO3sCwQ@mail.gmail.com>
<CAKKotZTm9+oH_mqkXviidB0-kUfRfXzM90Se0ymjyekdQdfzHQ@mail.gmail.com>
<CAKKotZT5R4knox3zH0E5A5gMn6TZ7qSR=c2-a1Qqc8cdj7+2Gg@mail.gmail.com>
<CAFOhELcXj-XwwdNz33c5jF8u1AL70hTbEVquTHcc6g-kXcgtHg@mail.gmail.com>
<CAFOhELezjboyr3SHAdazh1mmcTmNhH8XA6nig97CVpjCuNvEMw@mail.gmail.com>
Hi
On Wed, Mar 14, 2018 at 10:55 AM, Khushboo Vashi <
[email protected]> wrote:
> Hi,
>
> Please find the attached updated patch.
>
Can you add a unit test for set_env_variables() please?
>
> Thanks,
> Khushboo
>
> On Wed, Mar 14, 2018 at 1:07 PM, Khushboo Vashi <
> [email protected]> wrote:
>
>>
>>
>> On Wed, Mar 14, 2018 at 12:48 PM, Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> ../pgadmin4/web/pgadmin/tools/import_export/__init__.py +310 without
>>> your patch applied.
>>>
>>> Yes, good point. Will update and send the patch.
>>
>>>
>>> On Wed, Mar 14, 2018 at 12:39 PM, Murtuza Zabuawala <
>>> [email protected]> wrote:
>>>
>>>> Hi Khushboo,
>>>>
>>>> We can simplify this, we don't need to create any extra column,
>>>>
>>>> Check: ../pgadmin4/web/pgadmin/tools/import_export/__init__.py +322
>>>> where we are setting ENV variable we can create common utility function
>>>> (let say in ../tools/utils/__init__.py) which will set all required the
>>>> environment variables and then we will pass that function in p.start(..)
>>>> method.
>>>>
>>>>
>>>> --
>>>> Regards,
>>>> Murtuza Zabuawala
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>>
>>>> On Wed, Mar 14, 2018 at 11:03 AM, Khushboo Vashi <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> Please find the attached patch to fix RM #3122 : Backup not working on
>>>>> certificate (SSL) protected servers.
>>>>>
>>>>> The attached patch fixes the issue in the following modules:
>>>>>
>>>>> 1. Backup
>>>>> 2. Restore
>>>>> 3. Import/Export
>>>>> 4. Maintenance
>>>>>
>>>>> Thanks,
>>>>> Khushboo
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (8+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgadmin4][Patch]: RM #3122 - Backup not working on certificate (SSL) protected servers
In-Reply-To: <CA+OCxowueZFqvC96m7XJGrmSvjdXJ6jQOgP32QZ+JaUu+XdzxA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox