public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Harshal Dhumal <[email protected]>
Cc: Surinder Kumar <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Re: [pgAdmin4][Patch]: RM#1293 - SQL pane is not displaying GRANT queries in Function, Procedure and Trigger node
Date: Fri, 22 Jul 2016 16:38:36 +0100
Message-ID: <CA+OCxowvg_nbkU4_a-ZqvV1EnNpSP1sM3B0YUWruY-aVojPw7w@mail.gmail.com> (raw)
In-Reply-To: <CAFiP3vxn1oewux1O0gkvkKuciYeybq80apVtv2s10_Q0bfgq=A@mail.gmail.com>
References: <CAM5-9D_P=5wEc5phxDcf41y09gnxgAU++ffxCQL9qMkkOb203w@mail.gmail.com>
<CAM5-9D9sr70bxYvmOYdnpJdV+n+3PcEFXrUt_0dL-Mq9xtXboQ@mail.gmail.com>
<CAM5-9D-QEO1TngHhG24ZJTxA+oQqzJo6a7PgyQaUbf-ZXR+_wQ@mail.gmail.com>
<CAM5-9D84j2jj7nARiqsogOkXZw2oV71p+s2SamFesocVts50PQ@mail.gmail.com>
<CAFiP3vxn1oewux1O0gkvkKuciYeybq80apVtv2s10_Q0bfgq=A@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Thanks, applied.
On Fri, Jul 22, 2016 at 8:56 AM, Harshal Dhumal
<[email protected]> wrote:
> Hi,
>
> PFA rebased patch for RM1293 and RM1294.
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Mon, Jun 6, 2016 at 7:17 PM, Surinder Kumar
> <[email protected]> wrote:
>>
>> Hi,
>>
>> Please find updated patch:
>> Issue: Code changes are not consistent with the present code in
>> functions/__init__.py, like don't rename variable func_def to func_defintion
>> until it is required.
>> Review comment given by Ashesh personally.
>>
>> Please review.
>>
>> On Fri, Jun 3, 2016 at 3:31 PM, Surinder Kumar
>> <[email protected]> wrote:
>>>
>>> Hi,
>>>
>>> Please find attached patch for:
>>> 1. RM#1293 - SQL pane is not displaying GRANT queries in functions node
>>> 2. RM#1294 - Comments are not visible in sql pane for trigger functions
>>> and functions
>>>
>>> Explanation:
>>> Previously we we using 'get_defintion.sql' template to generate SQL for
>>> SQL pane for functions, procedure & trigger functions node.
>>> but GRANT statements and COMMENTS changes were missing. In order to fix
>>> that, now we have used both 'create.sql' and 'get_definition.sql' templates
>>> to generate full SQL query
>>> for SQL pane.
>>>
>>> Please review.
>>>
>>> On Thu, Jun 2, 2016 at 7:32 PM, Surinder Kumar
>>> <[email protected]> wrote:
>>>>
>>>> Please ignore this patch. I will send another patch.
>>>>
>>>> On Thu, Jun 2, 2016 at 7:25 PM, Surinder Kumar
>>>> <[email protected]> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> Please find attached patch for RM#1293.
>>>>> Add support to display GRANT privilege query in SQL Pane.
>>>>>
>>>>> Please review.
>>>>>
>>>>> Thanks,
>>>>> Surinder Kumar
>>>>
>>>>
>>>
>>
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list ([email protected])
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
view thread (6+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Re: [pgAdmin4][Patch]: RM#1293 - SQL pane is not displaying GRANT queries in Function, Procedure and Trigger node
In-Reply-To: <CA+OCxowvg_nbkU4_a-ZqvV1EnNpSP1sM3B0YUWruY-aVojPw7w@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox