public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Neel Patel <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][runtime][patch]: Runtime not working in all platform
Date: Mon, 8 Aug 2016 14:42:27 +0100
Message-ID: <CA+OCxowyUB546W14gxZ20wLb9cG1LS7XL_eAMWSF2oM+nCSBHQ@mail.gmail.com> (raw)
In-Reply-To: <CACCA4P1HeN9YL1Lpo-PSL9EVU7+xHneEP_ShHSTRQOkZDpnofQ@mail.gmail.com>
References: <CACCA4P1HeN9YL1Lpo-PSL9EVU7+xHneEP_ShHSTRQOkZDpnofQ@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Thanks, applied.

On Mon, Aug 8, 2016 at 2:11 PM, Neel Patel <[email protected]> wrote:
> Hi,
>
> Please find attached patch file to fix the below issue.
>
> Issue:-
> Runtime was not working in all platform due to syntax error in javascript.
> This issue was introduced due to below commit.
>
> Prevent the user attempting to run external commands if the bin path is not
> configured. Fixes #1177
>
> f78024808e80fef67de1aef5c97d1756c6771c0e
>
>
> It is working in browser but Qt's web engine is not able to handle the error
> and goes into infinite loop of paint event which may crash the pgAdmin4
> application.
>
> Can you please review and commit this patch ?
>
> Thanks,
> Neel Patel
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][runtime][patch]: Runtime not working in all platform
  In-Reply-To: <CA+OCxowyUB546W14gxZ20wLb9cG1LS7XL_eAMWSF2oM+nCSBHQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox