public inbox for [email protected]  

help / color / mirror / Atom feed

From: Neel Patel <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin4][runtime][patch]: Runtime not working in all platform
Date: Mon, 8 Aug 2016 18:41:44 +0530
Message-ID: <CACCA4P1HeN9YL1Lpo-PSL9EVU7+xHneEP_ShHSTRQOkZDpnofQ@mail.gmail.com> (raw)
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi,

Please find attached patch file to fix the below issue.

*Issue:-*
Runtime was not working in all platform due to syntax error in javascript.
This issue was introduced due to below commit.

Prevent the user attempting to run external commands if the bin path is not
configured. Fixes #1177

f78024808e80fef67de1aef5c97d1756c6771c0e

It is working in browser but Qt's web engine is not able to handle the
error and goes into infinite loop of paint event which may crash the
pgAdmin4 application.

Can you please review and commit this patch ?

Thanks,
Neel Patel


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [application/octet-stream] runtime_issue.patch (668B, 3-runtime_issue.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/templates/browser/js/browser.js b/web/pgadmin/browser/templates/browser/js/browser.js
index 95528b0..8910240 100644
--- a/web/pgadmin/browser/templates/browser/js/browser.js
+++ b/web/pgadmin/browser/templates/browser/js/browser.js
@@ -694,8 +694,8 @@ function(require, $, _, S, Bootstrap, pgAdmin, alertify, CodeMirror) {
       }
     },
 
-    get_preference(module, preference_name) {
-      preference = null;
+    get_preference: function (module, preference_name) {
+      var preference = null;
       $.ajax({
         async: false,
         url: "{{ url_for('preferences.preferences') }}" +"/"+ module +"/"+ preference_name,

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin4][runtime][patch]: Runtime not working in all platform
  In-Reply-To: <CACCA4P1HeN9YL1Lpo-PSL9EVU7+xHneEP_ShHSTRQOkZDpnofQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox