public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgadmin4][Patch]: Feature #2686 Property to switch lower/upper case auto completion
Date: Thu, 14 Jun 2018 08:44:18 +0100
Message-ID: <CA+OCxox1t8LR7byMFmNSexxxoVhLw6n6o3AbAoSV46ci8mDPuA@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDecb+ArijBx+cvz4fNEiWYyOcBA4mbFXk3X=wMeJGoOzQ@mail.gmail.com>
References: <CANxoLDecb+ArijBx+cvz4fNEiWYyOcBA4mbFXk3X=wMeJGoOzQ@mail.gmail.com>
Hi
On Thu, Jun 14, 2018 at 8:41 AM, Akshay Joshi <[email protected]
> wrote:
> Hi Hackers,
>
> Attached is the patch for the Feature #2686 Property to switch lower/upper
> case auto completion. I have added new preferences settings "Keywords in
> uppercase" if it is set to True then all the keywords are shown in upper
> case in auto completion.
>
> I have also implemented the second request in the RM to change the
> selected text to upper/lower case. For that I have added new keyboard
> shortcut "Toggle case of selected text" in preferences dialog. Default
> key is "Ctrl + Shift + u".
>
> Please review it.
>
I don't see any doc updates in the patch - seems like that was forgotten?
Any opportunities to re-factor the code in that area into more testable
functions?
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgadmin4][Patch]: Feature #2686 Property to switch lower/upper case auto completion
In-Reply-To: <CA+OCxox1t8LR7byMFmNSexxxoVhLw6n6o3AbAoSV46ci8mDPuA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox