public inbox for [email protected]  

help / color / mirror / Atom feed
From: Dave Page <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Regarding non-ascii characters in the path for Windows installer
Date: Fri, 17 Jan 2025 12:01:56 +0000
Message-ID: <CA+OCxox7H9hLn9CjKJQErqKXU+cbedaxW7aq1KLJfoRqUYO+-A@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDdq6E8uMHMqcMw_Qz4EFV_Fx4m_4fvwkmnU=YkFxEdqDg@mail.gmail.com>
References: <CANxoLDdq6E8uMHMqcMw_Qz4EFV_Fx4m_4fvwkmnU=YkFxEdqDg@mail.gmail.com>

Hi

On Thu, 16 Jan 2025 at 11:23, Akshay Joshi <[email protected]>
wrote:

> Hi Dave/Hackers
>
> I am looking into issue 5204
> <https://github.com/pgadmin-org/pgadmin4/issues/5204; where the pgAdmin 4
> Windows installer throws an error of "Please provide a valid path," when
> the user name contains non-ASCII characters.
>
> We have added a function IsPathValid to validate the path in the "
> installer.iss.in" file, because of this function Windows installer throws
> an error.
>
> [image: Code.png]
> Can we remove this logic? Thoughts/Suggestions?
>

I don't think we can just remove it - if memory serves, we added it because
we ran into issues in some cases. Obviously we can't do an exhaustive test,
but can we confirm that pgAdmin will work with at least some non-ASCII
characters in the path, e.g. some accented characters, Kanji, Cyrillic etc?

-- 
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
pgEdge: https://www.pgedge.com


Attachments:

  [image/png] Code.png (121.9K, 3-Code.png)
  download | view image

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Regarding non-ascii characters in the path for Windows installer
  In-Reply-To: <CA+OCxox7H9hLn9CjKJQErqKXU+cbedaxW7aq1KLJfoRqUYO+-A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox