public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin4] Fix help message alignment
4+ messages / 2 participants
[nested] [flat]
* [pgAdmin4] Fix help message alignment
@ 2019-01-23 12:27 Murtuza Zabuawala <[email protected]>
2019-01-24 14:03 ` Re: [pgAdmin4] Fix help message alignment Dave Page <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Murtuza Zabuawala @ 2019-01-23 12:27 UTC (permalink / raw)
To: pgadmin-hackers
Hi,
PFA minor patch to fix the default input control help message alignment
issue on properties panel.
*Without fix:*
[image: image.png]
*With fix:*
[image: image.png]
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachments:
[image/png] image.png (82.1K, 3-image.png)
download | view image
[image/png] image.png (70.0K, 4-image.png)
download | view image
[application/octet-stream] fix_help_message_alignment_on_properties_panel.diff (816B, 5-fix_help_message_alignment_on_properties_panel.diff)
download | inline diff:
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index a4ed36be..369243dc 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -163,10 +163,10 @@ define([
' <span class="<%=Backform.controlClassName%> uneditable-input" <%=disabled ? "disabled readonly" : ""%>>',
' <%-value%>',
' </span>',
+ ' <% if (helpMessage && helpMessage.length) { %>',
+ ' <span class="<%=Backform.helpMessageClassName%>"><%=helpMessage%></span>',
+ ' <% } %>',
'</div>',
- '<% if (helpMessage && helpMessage.length) { %>',
- ' <span class="<%=Backform.helpMessageClassName%>"><%=helpMessage%></span>',
- '<% } %>',
].join('\n')),
clearInvalid: function() {
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin4] Fix help message alignment
2019-01-23 12:27 [pgAdmin4] Fix help message alignment Murtuza Zabuawala <[email protected]>
@ 2019-01-24 14:03 ` Dave Page <[email protected]>
2019-01-24 14:49 ` Re: [pgAdmin4] Fix help message alignment Murtuza Zabuawala <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Dave Page @ 2019-01-24 14:03 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers
What RM is this please?
On Wed, Jan 23, 2019 at 12:27 PM Murtuza Zabuawala <
[email protected]> wrote:
> Hi,
>
> PFA minor patch to fix the default input control help message alignment
> issue on properties panel.
>
> *Without fix:*
> [image: image.png]
>
> *With fix:*
> [image: image.png]
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachments:
[image/png] image.png (82.1K, 3-image.png)
download | view image
[image/png] image.png (70.0K, 4-image.png)
download | view image
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin4] Fix help message alignment
2019-01-23 12:27 [pgAdmin4] Fix help message alignment Murtuza Zabuawala <[email protected]>
2019-01-24 14:03 ` Re: [pgAdmin4] Fix help message alignment Dave Page <[email protected]>
@ 2019-01-24 14:49 ` Murtuza Zabuawala <[email protected]>
2019-01-24 16:40 ` Re: [pgAdmin4] Fix help message alignment Dave Page <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Murtuza Zabuawala @ 2019-01-24 14:49 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
Hi Dave,
I have created https://redmine.postgresql.org/issues/3929.
On Thu, Jan 24, 2019 at 7:33 PM Dave Page <[email protected]> wrote:
> What RM is this please?
>
> On Wed, Jan 23, 2019 at 12:27 PM Murtuza Zabuawala <
> [email protected]> wrote:
>
>> Hi,
>>
>> PFA minor patch to fix the default input control help message alignment
>> issue on properties panel.
>>
>> *Without fix:*
>> [image: image.png]
>>
>> *With fix:*
>> [image: image.png]
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
Attachments:
[image/png] image.png (82.1K, 3-image.png)
download | view image
[image/png] image.png (70.0K, 4-image.png)
download | view image
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin4] Fix help message alignment
2019-01-23 12:27 [pgAdmin4] Fix help message alignment Murtuza Zabuawala <[email protected]>
2019-01-24 14:03 ` Re: [pgAdmin4] Fix help message alignment Dave Page <[email protected]>
2019-01-24 14:49 ` Re: [pgAdmin4] Fix help message alignment Murtuza Zabuawala <[email protected]>
@ 2019-01-24 16:40 ` Dave Page <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: Dave Page @ 2019-01-24 16:40 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers
Thanks - patch applied.
On Thu, Jan 24, 2019 at 2:50 PM Murtuza Zabuawala <
[email protected]> wrote:
> Hi Dave,
>
> I have created https://redmine.postgresql.org/issues/3929.
>
>
> On Thu, Jan 24, 2019 at 7:33 PM Dave Page <[email protected]> wrote:
>
>> What RM is this please?
>>
>> On Wed, Jan 23, 2019 at 12:27 PM Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> PFA minor patch to fix the default input control help message alignment
>>> issue on properties panel.
>>>
>>> *Without fix:*
>>> [image: image.png]
>>>
>>> *With fix:*
>>> [image: image.png]
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachments:
[image/png] image.png (82.1K, 3-image.png)
download | view image
[image/png] image.png (70.0K, 4-image.png)
download | view image
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2019-01-24 16:40 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-01-23 12:27 [pgAdmin4] Fix help message alignment Murtuza Zabuawala <[email protected]>
2019-01-24 14:03 ` Dave Page <[email protected]>
2019-01-24 14:49 ` Murtuza Zabuawala <[email protected]>
2019-01-24 16:40 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox