public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: Khushboo Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query
Date: Mon, 26 Feb 2018 16:32:16 +0000
Message-ID: <CA+OCxoxAeFzZncavJLcXag0CSYz1x7tfY5tpDT7kJ0tkv=CTYA@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZS65W+Q5o0isYV_SRGGRFjntFOKeMDFW7WfqPYP4U_ANw@mail.gmail.com>
References: <[email protected]>
	<CAKKotZT33y_ZcFAovFz7VaLq=Xfv1beTFVLUSP4B0_oh_VNxkQ@mail.gmail.com>
	<CAKKotZS65W+Q5o0isYV_SRGGRFjntFOKeMDFW7WfqPYP4U_ANw@mail.gmail.com>

Argh, I ran some tests, but didn't spot any lost messages in the tests I
ran. I'll revert the patch.

Khushboo;

Please look at the following:

- Fix the patch so it doesn't drop messages.
- Add regression tests to make sure it doesn't break in the future. This
may require creating one or more functions the spew out a whole lot of
notices, and then running a couple of queries and checking the output.
- Check the messages panel on the history tab. I just noticed it seems to
only be showing an even smaller subset of the messages.

Thanks.

On Mon, Feb 26, 2018 at 4:23 PM, Murtuza Zabuawala <
[email protected]> wrote:

> Sent bit early,
>
> You can run 'VACUUM FULL VERBOSE' in query tool and verify the populated
> messages (pgAdmin3 vs. pgAdmin4).
>
>
> On Mon, Feb 26, 2018 at 9:48 PM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Hi Khushboo/Dave,
>>
>> With given commit, I'm again seeing the issue raised in
>> https://redmine.postgresql.org/issues/1523 :(
>>
>>
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> On Mon, Feb 26, 2018 at 7:49 PM, Dave Page <[email protected]> wrote:
>>
>>> Ensure we pick up the messages from the current query and not a previous
>>> one. Fixes #3094
>>>
>>> Branch
>>> ------
>>> master
>>>
>>> Details
>>> -------
>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>>> f;h=08b3ccc01a4d57e8ea3657f8882a53dcd1b99386
>>> Author: Khushboo Vashi <[email protected]>
>>>
>>> Modified Files
>>> --------------
>>> web/pgadmin/utils/driver/abstract.py          |  1 +
>>> web/pgadmin/utils/driver/psycopg2/__init__.py | 64
>>> +++++++++------------------
>>> 2 files changed, 21 insertions(+), 44 deletions(-)
>>>
>>>
>>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

view thread (17+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query
  In-Reply-To: <CA+OCxoxAeFzZncavJLcXag0CSYz1x7tfY5tpDT7kJ0tkv=CTYA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox