public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Paresh More <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Sandeep Thakkar <[email protected]>
Cc: Hamid Quddus <[email protected]>
Subject: Re: PATCH: pgAdmin4 windows installer
Date: Wed, 8 Jun 2016 12:31:30 +0100
Message-ID: <CA+OCxoxEZ9x02GXvgLuED3fwFae8-XQvdXFhQ03GCZ0=sb8-Yw@mail.gmail.com> (raw)
In-Reply-To: <CAAgiCNF+PSOA9dsUf90dCDLTqj9GEzA-qT7gNk5q9RqFj+0Aqg@mail.gmail.com>
References: <CAAgiCNHk3BKirjx=RrCzVtXWPAESVyCjvFfJ2hBKWXi8yz5VHQ@mail.gmail.com>
<CA+OCxoxjzNG4L8OFhwfP_x9eUiS2SW09r5wmr1EMxr6GGZugbw@mail.gmail.com>
<CAAgiCNHuAaJRSeVg39R3LfJ8eu5=X2Ljn1DjPoB=XmXwwCMqRw@mail.gmail.com>
<CA+OCxoz8Cui4eHVSyaCqh++_xKMrcQkKB8Rc0pjqEdzg0Un79w@mail.gmail.com>
<CAAgiCNEF4_=Q=58tC78eXozoBRHiWsRdU=W_BY3ubhrKwyG1-g@mail.gmail.com>
<CA+OCxoxXq2bWG+EQjMKDNH-we2VJcKzPGMub=SVVfjdfum+PHA@mail.gmail.com>
<CAAgiCNFL6v=Fb9KDacY2o-KvL3zb4C4MMaTPp4Tzk=-6CYbc=w@mail.gmail.com>
<CAAgiCNF6+kc=ZODe7OSUQ2iS8u0O6UCeg3t_gEL78b92h42xBw@mail.gmail.com>
<CA+OCxoxhF0wLw131aBMNBLabNsV=wRS9OV7zv54w+97TOPa_Ag@mail.gmail.com>
<CA+OCxoztEfCmDLYYiETwZEkhzwJa72kVgNKHh9nh9Z6rrMj7rQ@mail.gmail.com>
<CAAgiCNFRtpWqtW7Ka_rjCgTLmH3jEBA-kr-ph_GnpqFJxshHdQ@mail.gmail.com>
<CA+OCxox=i5VvgG=rThPPbu9uhECNhS7mYjtS2mSqeN9inAXfag@mail.gmail.com>
<CAAgiCNEU7tXBJWD=N9dM9uW+bJzVe_MY-hjAm38WhiL0gPvVsA@mail.gmail.com>
<CA+OCxoxrAh+Y=FLV9PoWdkseKCd6tecxTz+gHfWQ6RWSXiOUpg@mail.gmail.com>
<CAAgiCNF+PSOA9dsUf90dCDLTqj9GEzA-qT7gNk5q9RqFj+0Aqg@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Thanks! That's now committed, with a few modifications:
- Install/uninstall Sphinx as it's not actually in the requirements.txt
file and is only needed for building.
- Detect errors in the doc build.
- Rename ve_python to venv for consistency with Mac.
- Comment/progress info improvements
On Wed, Jun 8, 2016 at 7:23 AM, Paresh More <[email protected]>
wrote:
> Hello Dave,
>
> As discuss added vcdist runtime, remove splash screen and added start menu
> icon.
>
> Now also inno setup standard and Unicode both version are working fine.
>
>
>
> Attached is the updated patch.
>
>
> On Mon, Jun 6, 2016 at 2:51 PM, Dave Page <[email protected]> wrote:
>
>> Hi,
>>
>> On Fri, Jun 3, 2016 at 9:30 PM, Paresh More <[email protected]
>> > wrote:
>>
>>> Hello Dave.
>>>
>>> There was problem with the Make.bat file ^M characters which is been
>>> removed.
>>>
>>> Issues are fixed along with some code and README tidied
>>>
>>
>> I'm still seeing the same error:
>>
>> copy "C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss.in"
>> "C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss"
>> 1 file(s) copied.
>> Error on line 113 in
>> C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss: Column 3:
>> Semicolon (';') expected.
>> Compile aborted.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
>
> Thanks & Regards
>
> *Paresh More*
>
> [image: NEW-EDB-logo-4c]
>
> Pune, India.
> Cell : +919922000564 | www.enterprisedb.com
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (20+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: PATCH: pgAdmin4 windows installer
In-Reply-To: <CA+OCxoxEZ9x02GXvgLuED3fwFae8-XQvdXFhQ03GCZ0=sb8-Yw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox