public inbox for [email protected]  
help / color / mirror / Atom feed
From: Dave Page <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Nikhil Mohite <[email protected]>
Subject: Re: RM 6427 - Newlines in text columns of resultset show an allegedly "empty" field
Date: Thu, 1 Jul 2021 09:18:34 +0100
Message-ID: <CA+OCxoxKLYhikMGLUVVW=EVMQ_8dEKLv24r=HoXGmaaqgjvaHQ@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxowvrwWYCmpLXGkRXsAd9M1bJY0hD4OV6es5qJ1KZ55xzg@mail.gmail.com>
References: <CA+OCxozRoYYgSp+BRrovk31uzn4sB0JCL6ztcgaOjpx6qnfbqA@mail.gmail.com>
	<CAFOhELd7fo_bxqrOfdhgPV4Pb5b_O+bYyTR9ooj40RaNpMeXMQ@mail.gmail.com>
	<CA+OCxowvrwWYCmpLXGkRXsAd9M1bJY0hD4OV6es5qJ1KZ55xzg@mail.gmail.com>

Thanks, committed.

On Wed, Jun 30, 2021 at 1:11 PM Dave Page <[email protected]> wrote:

> Hi
>
> On Wed, Jun 30, 2021 at 12:36 PM Khushboo Vashi <
> [email protected]> wrote:
>
>> Hi Dave,
>>
>> On Wed, Jun 30, 2021 at 3:35 PM Dave Page <[email protected]> wrote:
>>
>>> Here's a simple patch for $SUBJECT. It will remove any leading spaces
>>> from the grid cell display and replace them with '[...] '. In edit mode,
>>> the data is unchanged.
>>>
>>> The patch looks good to me.
>>
>
> Thanks.
>
>
>> Do we need to specify somewhere what is [...] ?
>>
>
> I don't think there's much point.
>
>
>>
>> The only downside I can see to this is that the tooltip will show the
>>> modified data when it probably should actually show the un-modified data.
>>> Unfortunately that's handled by a SlickGrid plugin, which would have to be
>>> vendorised and modified (perhaps non-trivially). I don't think that's a big
>>> issue though.
>>>
>>> --
>>> Dave Page
>>> Blog: https://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EDB: https://www.enterprisedb.com
>>>
>>>
>
> --
> Dave Page
> Blog: https://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EDB: https://www.enterprisedb.com
>
>

-- 
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: https://www.enterprisedb.com


view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: RM 6427 - Newlines in text columns of resultset show an allegedly "empty" field
  In-Reply-To: <CA+OCxoxKLYhikMGLUVVW=EVMQ_8dEKLv24r=HoXGmaaqgjvaHQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox