public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Date: Mon, 11 Nov 2019 09:08:01 +0000
Message-ID: <CA+OCxoxKgZFwtqhc89Pu3T_aPWkTmt4_rO32WuewaDLqoLM7wg@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_=fuDGpPmFLg=w--LCF1jACMuWcqGb5BFX57AhE-Vm4xQ@mail.gmail.com>
References: <CAM9w-_m5mfGiu1mUH28Hngi1riYTmTurNoxz-qWOH7g+zRFOhA@mail.gmail.com>
	<CAM9w-_nNp1BAy9usd1j9xP+gKSrR-_BLMwoCUzngx0-8HcbRmw@mail.gmail.com>
	<CANxoLDcAnDBA-a5577wo0QcXVq0bmk+DPKv=K7nekRiejcPXzA@mail.gmail.com>
	<CA+OCxozmGJmLvH1g0vCn09OOTiUTnZbZ_nPHU0dNU1pRXYjQnA@mail.gmail.com>
	<CA+OCxow-ZLN8sKETj5Bf7Y4gTWm+q7NtugfpG3_zt-KHzpvbJA@mail.gmail.com>
	<CAM9w-_=fuDGpPmFLg=w--LCF1jACMuWcqGb5BFX57AhE-Vm4xQ@mail.gmail.com>

Hi

On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal <
[email protected]> wrote:

> Hi Dave,
>
> On Thu, Nov 7, 2019 at 7:56 PM Dave Page <[email protected]> wrote:
>
>>
>>
>> On Thu, Nov 7, 2019 at 2:18 PM Dave Page <[email protected]> wrote:
>>
>>>
>>> On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <
>>> [email protected]> wrote:
>>>
>>>> Thanks, patch applied.
>>>>
>>>> On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>> Attached is the updated patch with few more changes and corrections.
>>>>> Kindly review.
>>>>>
>>>>
>>> I've committed a couple of minor tweaks - one to remove a space, e.g.
>>>
>>> gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now ?'),
>>>
>>> is now:
>>>
>>> gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now?'),
>>>
>>> And another change to fix the word wrapping in the README which was
>>> totally different from the rest of the file.
>>>
>>> Thanks!
>>>
>>
>> Oh, and do we need all the code in config.py? I really didn't even want a
>> config option in there to turn theming on or off (what's the point?), let
>> alone 20 new lines.
>>
> The code is added after the config_local and config_distro is loaded. So,
> user won't be able to disable it unless he directly changes the config.py.
>

That is clearly wrong and needs to be fixed. config_local and config_distro
should be able to override anything in config.py.

But... why allow the themes to be updated or disabled at all? It's not like
a non-developer can add new ones, and it's not a security issue that an
administrator might need to control. In fact, it's arguably an
accessibility feature, for those whose eyes (like mine) last the day better
with a darker theme.

Let's remove it entirely please. I don't see any good reason to have any of
that in config.py.

Thanks.


> I'll reduce the code a bit.
>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

view thread (31+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
  In-Reply-To: <CA+OCxoxKgZFwtqhc89Pu3T_aPWkTmt4_rO32WuewaDLqoLM7wg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox