public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Date: Thu, 7 Nov 2019 14:18:16 +0000
Message-ID: <CA+OCxozmGJmLvH1g0vCn09OOTiUTnZbZ_nPHU0dNU1pRXYjQnA@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDcAnDBA-a5577wo0QcXVq0bmk+DPKv=K7nekRiejcPXzA@mail.gmail.com>
References: <CAM9w-_m5mfGiu1mUH28Hngi1riYTmTurNoxz-qWOH7g+zRFOhA@mail.gmail.com>
	<CAM9w-_nNp1BAy9usd1j9xP+gKSrR-_BLMwoCUzngx0-8HcbRmw@mail.gmail.com>
	<CANxoLDcAnDBA-a5577wo0QcXVq0bmk+DPKv=K7nekRiejcPXzA@mail.gmail.com>

On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <[email protected]>
wrote:

> Thanks, patch applied.
>
> On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Attached is the updated patch with few more changes and corrections.
>> Kindly review.
>>
>
I've committed a couple of minor tweaks - one to remove a space, e.g.

gettext('A page refresh is required to apply the theme. Do you wish to
refresh the page now ?'),

is now:

gettext('A page refresh is required to apply the theme. Do you wish to
refresh the page now?'),

And another change to fix the word wrapping in the README which was totally
different from the rest of the file.

Thanks!


>> On Wed, Nov 6, 2019 at 12:32 PM Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to introduce theme options in pgAdmin.
>>> Changes include:
>>> 1) New theme option in preferences - Miscellaneous -> Themes. You can
>>> select the theme from the dropdown. It also has a preview of the theme just
>>> below the dropdown. Note that, a page refresh is needed to apply changes.
>>> On saving, a dialog appears to ask for refresh.
>>> 2) You can create your own theme and submit to hackers. README is
>>> updated to help you create a theme. Theme will be available only after
>>> bundle.
>>> 3) Correction of SASS variables at few places and few other CSS
>>> corrections.
>>> 4) Added iconfont-webpack-plugin, which will convert all the svg
>>> files(monochrome) used as icons for buttons to font icons. This will allow
>>> us to change the color of icon by using CSS color property.
>>> 5) All the .css files will bundle into a separate file now-
>>> pgadmin.style.css. This will help reduce the size of theme css files as CSS
>>> in .css files will not change with the change of SASS variables.
>>> 6) "Dark Beta" theme added as a new theme option.
>>>
>>> How theme is built ?
>>> Webpack config is changed to achieve it. On running yarn run bundle,
>>> code will read all the directories in web/pgadmin/static/scss/resources
>>> which will be considered as theme dirs, build a separate css for every
>>> theme and then create a file named pgadmin.themes.json which will have all
>>> the information required.
>>>
>>> The patch also fixes RM4173, where there some issue with arrow icons in
>>> browser tree.
>>>
>>> Kindly review.
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

view thread (31+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
  In-Reply-To: <CA+OCxozmGJmLvH1g0vCn09OOTiUTnZbZ_nPHU0dNU1pRXYjQnA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox