public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgadmin4][Patch]: Fixed minor issue in auto discover server when entry is blank in the config file
Date: Thu, 21 Jun 2018 21:35:01 +0100
Message-ID: <CA+OCxoxP=UJA_gd8oO4_2HVF6q8W9=YAKZ+BRNymKo4g9kv+pw@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDcyq+oLtrU_yoFjHrtsU0YQBqDZ5fB0bO7V8FCrCrKO9w@mail.gmail.com>
References: <CANxoLDcyq+oLtrU_yoFjHrtsU0YQBqDZ5fB0bO7V8FCrCrKO9w@mail.gmail.com>
Thanks, applied.
On Thu, Jun 21, 2018 at 8:32 AM, Akshay Joshi <[email protected]
> wrote:
> Hi Hackers,
>
> I have found one minor issue in auto discovery logic. *getint* function
> of ConfigParser throws exception if the value of the parameter is blank
> in the config file. Example: *Port=*
>
> Because of that exception pgAdmin4 unable to discover all the valid
> servers. Attached is the patch to fix that. Please review it.
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgadmin4][Patch]: Fixed minor issue in auto discover server when entry is blank in the config file
In-Reply-To: <CA+OCxoxP=UJA_gd8oO4_2HVF6q8W9=YAKZ+BRNymKo4g9kv+pw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox