public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Ashesh Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: PATCH: pgAgent support
Date: Mon, 26 Sep 2016 10:06:03 +0100
Message-ID: <CA+OCxox_Q1yj9-h4Sz2PJsj0hmUXQn5GxQ+g+ZV0oVfivZCRKg@mail.gmail.com> (raw)
In-Reply-To: <CAG7mmoxiBxBqbu8=36N3UhQ6QSUTTFHJrTvg_Q12VaqUZsDwhQ@mail.gmail.com>
References: <CAG7mmozpAhowsCTTs1nCqxJ=VCGS42-v=py-Ev-pXoSCFzSOMg@mail.gmail.com>
<CA+OCxozmX2ZVYG9ors8XVisMMvf1uf4FL8Rx=ATuCiJv9RyVFQ@mail.gmail.com>
<CAG7mmow884db7H85tx8myz76Jr6HyZLfhJwNTSWmHEFzEcCPpg@mail.gmail.com>
<CA+OCxox1dkmj2j3WZXZM7ktQnVpyH_M1cULoG+nL-z=JxqowNA@mail.gmail.com>
<CAG7mmozCem=oAs-fa8HJF=FTUb0aSUP9=OavRjSS_fz51MgW+w@mail.gmail.com>
<CA+OCxowCbSc3GtRtnCjeweVTmDZAdzK6DX8g30iL=LcDq2ayOg@mail.gmail.com>
<CAG7mmoxiBxBqbu8=36N3UhQ6QSUTTFHJrTvg_Q12VaqUZsDwhQ@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi
I've applied the misc changes patch, but it looks like you forgot the
--binary option for the pgAgent patch. Can you recreate it please?
Thanks.
On Fri, Sep 23, 2016 at 9:34 PM, Ashesh Vashi <[email protected]
> wrote:
> Hi Dave,
>
>
> On Thu, Sep 22, 2016 at 8:27 PM, Dave Page <[email protected]> wrote:
>
>> Thanks. From the pgAgent patch:
>>
>> - The date/time format is different again. Should be locale or ISO
>> (consistent across the app)
>>
> Using ISO now.
>
>>
>> - I think we need to add hints under the less obvious options - e.g.
>> Job class and host agent
>>
> I added few string.
> Will need your feedback on that.
>
>>
>> - On the job step subnode control, lets move the Script to it's own
>> tab (called Code). We should alter the label based on the Kind option
>> - either "SQL query" or "Script"
>>
> Done
>
>>
>> - Why can't we use the Date/time picker for Exceptions? I assume we
>> just need to either disable Date or Time selection?
>>
> Done.
>
> I was avoiding to show date time picker for multiple reasons:
> 1. It needed a special effort to show datetime picker in the backgrid cell.
> 2. The datetime picker did not fit in the subnode control.
>
> A special DatetimePickerCell was needed to be created the cell with
> datetime picker.
> And, I had to specify the min-height in the exceptions tab as a hack.
>
>>
>> - The SQL tab doesn't use the available space. See screenshot.
>>
> Fixed.
>
> This was a general issue for the properties dialog having more than 550px.
> We have hardcoded the height to 500px of CodeMirror in the SQL tab.
>
>>
>> - The SQL should have blank lines between sections, e.g. before --
>> Steps and -- Schedules
>>
> Done.
>
> Also - fixed an issue of setting the helpMessage in SwitchControl.
>
> Again - attaching two patches.
> 1. Misc changes
> - Setting the CodeMirror height when panel is resized, which you had
> mentioned.
> - Added a new CellEditor (DatetimePickerEditor) for datetime picker.
> 2. pgAgent support (updated)
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com/;
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi;
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (13+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: PATCH: pgAgent support
In-Reply-To: <CA+OCxox_Q1yj9-h4Sz2PJsj0hmUXQn5GxQ+g+ZV0oVfivZCRKg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox