public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Thomas Greenwood <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Feature #6395 - Basic Log Rotation
Date: Tue, 20 Apr 2021 11:23:39 +0100
Message-ID: <CA+OCxoxeo21YAfGiWBPxon2DNnNFYK4=qHWBgsGjctx6g8dq2w@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
Hi
On Mon, Apr 19, 2021 at 5:17 PM Thomas Greenwood <[email protected]>
wrote:
> Hi,
>
> I've opened feature issue #6395 to enable log rotation in pgAdmin4 v5.
>
> Please find the attached basic patch as a starter for 10. It's the same
> patch attached to the feature issue.
>
Nice! My only suggestions would be that the config options be added to
config.py, with default values of zero for log size, and say, 5 for the
number of backups (should that be 'archives'?), and that we test to see if
the log size is > 0 before enabling rotation. The reason for that is that
we keep all config options in config.py to ensure it's self-documenting.
--
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake
EDB: https://www.enterprisedb.com
view thread (4+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Feature #6395 - Basic Log Rotation
In-Reply-To: <CA+OCxoxeo21YAfGiWBPxon2DNnNFYK4=qHWBgsGjctx6g8dq2w@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox