public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Navnath Gadakh <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Kanchan Mohitey <[email protected]>
Subject: Re: pgAdmin IV : Unittest modular patch
Date: Tue, 9 Aug 2016 16:06:04 +0100
Message-ID: <CA+OCxoxj+V-nN7NrtACczFDZzUuQsfcuttnyjd1xZEgXKtVNsg@mail.gmail.com> (raw)
In-Reply-To: <CAOAJCYr2RpCFPFzDq9N6R7VePPCMEriFgUNmscW5N-YGKJfENg@mail.gmail.com>
References: <CAOAJCYrcxBN2J_3dWq0Cwc82fkugzUi3NKD4jKoTKRBot=ev8w@mail.gmail.com>
<CAOAJCYpSBXcfEC5d4Sv_=jV86m1=rKUK0tMkZFhdSHkPb=XT3A@mail.gmail.com>
<CA+OCxowW0wjpNT-o0YF1Bg9rtD6Z7sqp35ZRUgoEguVKO4OtSw@mail.gmail.com>
<CAOAJCYr1JwYK4x2wDYw2UVAZoXC5a0FQT7Yz1Y_Wn46kzPMmQg@mail.gmail.com>
<CA+OCxoxqahNgLmvQqqErQZL2JS0EaQwyXkgkzvkFtGNh0OKV6w@mail.gmail.com>
<CAOAJCYqQQ4MaudVaVwfcateuxum-W39HwRiEorhYP8zbqjxN0g@mail.gmail.com>
<CA+OCxozZVCwB4t6hXjMeHbBV8Fx1cm_Cg1tknjWyYxLFZNYsEQ@mail.gmail.com>
<CAFOhELes8Vu_VciiVu31wfaYtTuCFUReEF1mfNXB4nSMcTNrHA@mail.gmail.com>
<CAOAJCYpY=u4T38s+XqQDOky10e7A_Wb_q9bbiwhx_=eF-6i-dQ@mail.gmail.com>
<CA+OCxoxm9_f5PJVLhwrSk6bozmivv_-=o+spffXjkYk+qPDKeg@mail.gmail.com>
<CAOAJCYpcye6nQAPB8os9vZXOhAf9wEvr6rA9i4vuZLDVrRYF0g@mail.gmail.com>
<CA+OCxowE5D0N2oq-Da+eXh4+cZMA3=GqB85-nE+YHuaACfjhbQ@mail.gmail.com>
<CAOAJCYonmDD-oqjwhJNVpWVHxyf-bTn_eJ8o7wNMr7sOOpBvkA@mail.gmail.com>
<CA+OCxozHiy2UsJp6jvYRNfYv3RWTijdFeoPuZH4dqyyT-knnjQ@mail.gmail.com>
<CAOAJCYo4Lyc3f+-6a7cYxsxjn9GKG7j7R8VYiDmxgrntyds-xg@mail.gmail.com>
<CA+OCxoxKo1L9ZNH81h-kmzWvzn7Pj=T4fUnP6FpvchePpoAB0A@mail.gmail.com>
<CAOAJCYq94E=zhaVWWUORP62nSD-PJ2y2crJeL41Mmv-50i-VbQ@mail.gmail.com>
<CA+OCxoy2kSbeBDCYaXGKOvEZAtpEO7uviL5cPakNf0FM=C=dzg@mail.gmail.com>
<CAOAJCYpPicjz4cOsTHHGfMRN7qgeNwdvbkyS4ihy5FZYPgUyHQ@mail.gmail.com>
<CA+OCxowBEaow-6X1NzcA_i1qzKoiXJprh33s1wciriMup3_omA@mail.gmail.com>
<CAOAJCYrzjjrf-qpGH+rm4cWajvcYuyQH8jufqWBFL3qVAVpSoA@mail.gmail.com>
<CA+OCxozcDPW47_FMgfpqrTyVN4=Ldu7dqkFWRR_bvMkxBEQvWA@mail.gmail.com>
<CAOAJCYqj1BxDfATGR+VKoyacjSZ+f4rK5ZtGDz==JW7GC5FKMA@mail.gmail.com>
<CA+OCxoyi_BC++vo79HuYf9RF1YY6Q2CM=zRNT1eGn4nc-r5Vwg@mail.gmail.com>
<CAOAJCYqSdptT3Tyt+nNXxhMd5C2Z-u7yVM6TD4bUQUqE3nsQDg@mail.gmail.com>
<CA+OCxoyg+fVadtRSn4fQq=OjCcDfdYJd6mgPOwj2fTmq7mNadg@mail.gmail.com>
<CAOAJCYr2RpCFPFzDq9N6R7VePPCMEriFgUNmscW5N-YGKJfENg@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Thanks - applied with some minor wording and README tweaks.
On Tue, Aug 9, 2016 at 10:19 AM, Navnath Gadakh
<[email protected]> wrote:
> Hi Dave,
>
> On Mon, Aug 8, 2016 at 9:15 PM, Dave Page <[email protected]>
> wrote:
>>
>> Hi
>>
>> I guess you need to test if tablespace_path is omitted, not just empty?
>
> Yes, thats right.. Please find the updated patch.
>>
>>
>> This function test the add tablespace scenario (Check Tablespace Node) ...
>> ERROR
>>
>> ======================================================================
>> ERROR: setUpClass
>>
>> (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_put.TableSpaceUpdateTestCase)
>> ----------------------------------------------------------------------
>> Traceback (most recent call last):
>> File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/test_tbspc_put.py",
>> line 48, in setUpClass
>> cls.server_group, cls.server_ids)
>> File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py",
>> line 122, in add_table_space
>> data = get_tablespace_data(server_connect)
>> File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py",
>> line 41, in get_tablespace_data
>> config_test_data['spc_location'] = server_config['tablespace_path']
>> KeyError: 'tablespace_path'
>>
>> ======================================================================
>> ERROR: setUpClass
>>
>> (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_delete.TableSpaceDeleteTestCase)
>> ----------------------------------------------------------------------
>> Traceback (most recent call last):
>> File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/test_tbspc_delete.py",
>> line 46, in setUpClass
>> cls.server_group, cls.server_ids)
>> File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py",
>> line 122, in add_table_space
>> data = get_tablespace_data(server_connect)
>> File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py",
>> line 41, in get_tablespace_data
>> config_test_data['spc_location'] = server_config['tablespace_path']
>> KeyError: 'tablespace_path'
>>
>> ======================================================================
>> ERROR: setUpClass
>>
>> (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_get.TablespaceGetTestCase)
>> ----------------------------------------------------------------------
>> Traceback (most recent call last):
>> File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/test_tbspc_get.py",
>> line 45, in setUpClass
>> cls.server_group, cls.server_ids)
>> File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py",
>> line 122, in add_table_space
>> data = get_tablespace_data(server_connect)
>> File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py",
>> line 41, in get_tablespace_data
>> config_test_data['spc_location'] = server_config['tablespace_path']
>> KeyError: 'tablespace_path'
>>
>> ======================================================================
>> ERROR: runTest
>> (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_add.TableSpaceAddTestCase)
>> This function test the add tablespace scenario (Check Tablespace Node)
>> ----------------------------------------------------------------------
>> Traceback (most recent call last):
>> File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/test_tbspc_add.py",
>> line 47, in runTest
>> self.server_ids)
>> File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py",
>> line 122, in add_table_space
>> data = get_tablespace_data(server_connect)
>> File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py",
>> line 41, in get_tablespace_data
>> config_test_data['spc_location'] = server_config['tablespace_path']
>> KeyError: 'tablespace_path'
>>
>> ----------------------------------------------------------------------
>> Ran 14 tests in 9.326s
>>
>> FAILED (errors=4)
>>
>> On Mon, Aug 8, 2016 at 3:07 PM, Navnath Gadakh
>> <[email protected]> wrote:
>> > Hi Dave,
>> > Please find the updated patch for API unit test cases for Roles and
>> > Tablespaces nodes
>> > As we finalized
>> > Now,
>> > 1. The user will specify the tablespace path in test_config.json.in
>> > 2. If tablespace path not found, skip the test cases for that
>> > server(Only tablespace test cases)
>> > 3. Add the skipped test summary in the test result. (Now it's
>> > showing on
>> > console + in log file, but need to update in a final enhanced test
>> > summary
>> > report. Which is research point we will work on that after finishing all
>> > nodes API test cases)
>> > 4. Removed the test_ prefix from the values in the config files.
>> >
>> > Thanks!
>> >
>> >
>> > On Thu, Aug 4, 2016 at 5:55 PM, Dave Page <[email protected]>
>> > wrote:
>> >>
>> >> On Thu, Aug 4, 2016 at 1:02 PM, Navnath Gadakh
>> >> <[email protected]> wrote:
>> >> > Hi Dave,
>> >> >
>> >> > On Thu, Aug 4, 2016 at 4:04 PM, Dave Page
>> >> > <[email protected]>
>> >> > wrote:
>> >> >>
>> >> >> Hi
>> >> >>
>> >> >> On Thu, Aug 4, 2016 at 10:27 AM, Navnath Gadakh
>> >> >> <[email protected]> wrote:
>> >> >>
>> >> >> >> Oh - does the per-server config override the main config? That's
>> >> >> >> useful. So anything that's in test_advanced_config.py can be
>> >> >> >> overridden on a per-server basis in test_config.py?
>> >> >> >
>> >> >> > No.
>> >> >> > per-server i.e advance config(test_advanced_config.json.in)
>> >> >> > and
>> >> >> > main
>> >> >> > config(test_config.json) both are different files. In main config
>> >> >> > we
>> >> >> > just
>> >> >> > mention the server’s credentials.(We can also mention per server
>> >> >> > credentails) and in test_advanced_config.json.in(here we say
>> >> >> > per-server
>> >> >> > config)
>> >> >> > we mention the advanced configurations i.e. test data for each
>> >> >> > node.
>> >> >>
>> >> >> OK.
>> >> >>
>> >> >> > So, let's summarize the discussion:
>> >> >> > - Let user specify the tablespace path in
>> >> >> > test_advanced_config.json.in
>> >> >>
>> >> >> No - test_config.py. It should be per-server.
>> >> >
>> >> > We don't have a file named 'test_config.py' but we have a
>> >> > server's
>> >> > credential file named 'test_config.json'.
>> >> > So, you are saying the tablespace path to be added in
>> >> > 'test_config.json'.
>> >> > Am I correct?
>> >>
>> >> Yeah, sorry. It should be a property of the server configuration.
>> >>
>> >>
>> >> --
>> >> Dave Page
>> >> VP, Chief Architect, Tools & Installers
>> >> EnterpriseDB: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >>
>> >> Blog: http://pgsnake.blogspot.com
>> >> Twitter: @pgsnake
>> >
>> >
>> >
>> >
>> > --
>> > Thanks,
>> > Navnath Gadakh
>> > Software Engineer
>> > EnterpriseDB Corporation
>> > Mobile: +91 9975389878
>> >
>> >
>>
>>
>>
>> --
>> Dave Page
>> VP, Chief Architect, Tools & Installers
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>
>
>
>
> --
> Thanks,
> Navnath Gadakh
> Software Engineer
> EnterpriseDB Corporation
> Mobile: +91 9975389878
>
>
--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
view thread (29+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: pgAdmin IV : Unittest modular patch
In-Reply-To: <CA+OCxoxj+V-nN7NrtACczFDZzUuQsfcuttnyjd1xZEgXKtVNsg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox