public inbox for [email protected]  

help / color / mirror / Atom feed
From: Dave Page <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch] - RE-SQL and modified SQL tests for Check Constraint node
Date: Wed, 17 Jul 2019 13:25:23 +0100
Message-ID: <CA+OCxoxnSk6fVehiuFHTHMVO6et9rRszaZHz6t+3q9LG70t+nA@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELdj7mzZZsLCArB-UM+aJ9c_iywg1i0zSNgbDvYvBgL7rg@mail.gmail.com>
References: <CAFOhELePnGgBQnfowrkabLHauGBiXO9xNGM_hmCZ766PUPmtFQ@mail.gmail.com>
	<CA+OCxoyXS6oFFrr6nFGy3ZxnqM2gqeDmm0bxZwB97medjL9A=A@mail.gmail.com>
	<CAFOhELdj7mzZZsLCArB-UM+aJ9c_iywg1i0zSNgbDvYvBgL7rg@mail.gmail.com>

Thanks, patch applied.

On Tue, Jul 16, 2019 at 12:01 PM Khushboo Vashi <
[email protected]> wrote:

> Hi Dave,
>
> On Tue, Jul 16, 2019 at 2:05 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Tue, Jul 16, 2019 at 7:22 AM Khushboo Vashi <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch for the RE-SQL and modified SQL tests for
>>> check constraint node.
>>>
>>> For the table child nodes, *create table endpoint *with proper data is
>>> required in the JSON file.
>>> I have introduced one new parameter named *store_table_id* in the table
>>> create endpoint, so the created table ID will be stored for the rest of the
>>> scenarios
>>>
>>
>> This breaks the type tests :-(
>>
>> Fixed.
> Please find the attached updated patch.
>
> Thanks,
> Khushboo
>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


view thread (4+ messages)

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch] - RE-SQL and modified SQL tests for Check Constraint node
  In-Reply-To: <CA+OCxoxnSk6fVehiuFHTHMVO6et9rRszaZHz6t+3q9LG70t+nA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox