public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin4][RM4269] Navigating Switch cell using Tab key throws console error
2+ messages / 2 participants
[nested] [flat]
* [pgAdmin4][RM4269] Navigating Switch cell using Tab key throws console error
@ 2019-05-16 11:51 Murtuza Zabuawala <[email protected]>
2019-05-17 15:33 ` Re: [pgAdmin4][RM4269] Navigating Switch cell using Tab key throws console error Dave Page <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Murtuza Zabuawala @ 2019-05-16 11:51 UTC (permalink / raw)
To: pgadmin-hackers
Hi,
PFA patch to fix the issue where navigating Switch cell using Tab key
throws console error.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachments:
[application/octet-stream] RM_4269.diff (1.2K, 3-RM_4269.diff)
download | inline diff:
diff --git a/web/pgadmin/static/js/backgrid.pgadmin.js b/web/pgadmin/static/js/backgrid.pgadmin.js
index b717230c..804dc92d 100644
--- a/web/pgadmin/static/js/backgrid.pgadmin.js
+++ b/web/pgadmin/static/js/backgrid.pgadmin.js
@@ -545,20 +545,24 @@ define([
}
if (gotoCell) {
+ let command = new Backgrid.Command({
+ key: 'Tab',
+ keyCode: 9,
+ which: 9,
+ shiftKey: e.shiftKey,
+ });
setTimeout(function() {
+ // When we have Editable Cell
if (gotoCell.hasClass('editable')) {
e.preventDefault();
e.stopPropagation();
- var command = new Backgrid.Command({
- key: 'Tab',
- keyCode: 9,
- which: 9,
- shiftKey: e.shiftKey,
- });
self.model.trigger('backgrid:edited', self.model,
self.column, command);
- this.exitEditMode();
gotoCell.trigger('focus');
+ } else {
+ // When we have Non-Editable Cell
+ self.model.trigger('backgrid:edited', self.model,
+ self.column, command);
}
}, 20);
}
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgAdmin4][RM4269] Navigating Switch cell using Tab key throws console error
2019-05-16 11:51 [pgAdmin4][RM4269] Navigating Switch cell using Tab key throws console error Murtuza Zabuawala <[email protected]>
@ 2019-05-17 15:33 ` Dave Page <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Dave Page @ 2019-05-17 15:33 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers
Thanks, patch applied.
On Thu, May 16, 2019 at 12:52 PM Murtuza Zabuawala <
[email protected]> wrote:
> Hi,
>
> PFA patch to fix the issue where navigating Switch cell using Tab key
> throws console error.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2019-05-17 15:33 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-05-16 11:51 [pgAdmin4][RM4269] Navigating Switch cell using Tab key throws console error Murtuza Zabuawala <[email protected]>
2019-05-17 15:33 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox