public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Chethana Kumar <[email protected]>
Subject: Re: pgAdmin 4 commit: Use a 'play' icon for the Execute Query button in the
Date: Thu, 5 Dec 2019 08:16:50 -0500
Message-ID: <CA+OCxoxzBB36MrrHkhf7O7k9_90TQhva65+yHwXvvvfNf8S0iQ@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDc6CNK0VZcMVti5=T4ctaKeYzJtv=9bNRc0XOMbu=q7kg@mail.gmail.com>
References: <[email protected]>
<CAM9w-_nxt1imJCKvCGaZu0tSdOmHZXfeWXgJxkgxMVzYScxKsw@mail.gmail.com>
<CA+OCxoyPUrrLmtQHv9UM9oyoh9w4RyE2QeJCSD-bbLrjZbbXnA@mail.gmail.com>
<CAM9w-_nEu37PsKRGLNeEEQLMfjpnYWmBfDCFa6p5sCxT2BTFaA@mail.gmail.com>
<CANxoLDcOSEVKmr0Vh=M80Ww23Y=bN+vJ7Ep3PaKCJoism-mY1g@mail.gmail.com>
<CANxoLDc6CNK0VZcMVti5=T4ctaKeYzJtv=9bNRc0XOMbu=q7kg@mail.gmail.com>
Yes, go ahead.
On Wed, Dec 4, 2019 at 11:24 PM Akshay Joshi <[email protected]>
wrote:
> Dave,
>
> Any update on this? Should I commit the patch?
>
> On Wed, 4 Dec, 2019, 11:57 Akshay Joshi, <[email protected]>
> wrote:
>
>> Hi Dave,
>>
>> Should I commit this patch, are you happy with the new icons?
>>
>> On Tue, Dec 3, 2019 at 4:13 PM Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>> Hi Dave,
>>>
>>> I've sent a patch for the new icon. It is not a play icon but thoughts
>>> on the sent patch ? Below is the icon:
>>> [image: toolbar.png]
>>>
>>> On Tue, Dec 3, 2019 at 4:09 PM Dave Page <[email protected]> wrote:
>>>
>>>> I intentionally didn't change that one as I wasn't sure what icon would
>>>> be better. I'm far from convinced that it should also be a play icon.
>>>>
>>>> On Tue, Dec 3, 2019 at 5:08 AM Aditya Toshniwal <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>> Attached is the patch to change toolbar icon for opening query tool
>>>>> inline with execute button change.
>>>>> Icon for table filter button on the toolbar is also changed as below:
>>>>> [image: toolbar.png]
>>>>>
>>>>> On Tue, Dec 3, 2019 at 7:15 AM Dave Page <[email protected]> wrote:
>>>>>
>>>>>> Use a 'play' icon for the Execute Query button in the Query Tool for
>>>>>> greater consistency with other applications. Fixes #4711
>>>>>>
>>>>>> Branch
>>>>>> ------
>>>>>> master
>>>>>>
>>>>>> Details
>>>>>> -------
>>>>>>
>>>>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ac2bd5e6ee7c41d5fc2f4ee0036042ac79ff...
>>>>>>
>>>>>> Modified Files
>>>>>> --------------
>>>>>> docs/en_US/release_notes_4_16.rst | 1 +
>>>>>> web/pgadmin/tools/datagrid/templates/datagrid/index.html | 2 +-
>>>>>> 2 files changed, 2 insertions(+), 1 deletion(-)
>>>>>>
>>>>>>
>>>>>
>>>>> --
>>>>> Thanks and Regards,
>>>>> Aditya Toshniwal
>>>>> Sr. Software Engineer | EnterpriseDB India | Pune
>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
--
Dave Page
VP & Chief Architect, Database Infrastructure
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
Attachments:
[image/png] toolbar.png (37.2K, 3-toolbar.png)
download | view image
[image/png] toolbar.png (37.2K, 4-toolbar.png)
download | view image
view thread (8+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: pgAdmin 4 commit: Use a 'play' icon for the Execute Query button in the
In-Reply-To: <CA+OCxoxzBB36MrrHkhf7O7k9_90TQhva65+yHwXvvvfNf8S0iQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox