public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: PATCH: Adding more confirmations in query tool (pgAdmin4)
Date: Wed, 7 Sep 2016 14:00:26 +0100
Message-ID: <CA+OCxoy0ZVietUm3piNLjApyUwnqZBUGSUPq_ct=Mfh6WQn=DA@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZTLPHRfS0W13pw9X9yViuGho_D6gn31BtU54WbMsx3VBg@mail.gmail.com>
References: <CAKKotZTLPHRfS0W13pw9X9yViuGho_D6gn31BtU54WbMsx3VBg@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi

On Wed, Sep 7, 2016 at 10:38 AM, Murtuza Zabuawala
<[email protected]> wrote:
> Hi,
>
> PFA patch to add more confirmations in query tool before taking any actions
> which might cause lose changes,
> - Clearing editor
> - Clearing history
> - Load file data
>  RM#1666
>
> Please review.

Can you tweak it so that the confirmation is requested as soon as the
open file button is clicked, rather than when a file is selected
please? I think that's a little more 'normal' :-).

Thanks!

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: PATCH: Adding more confirmations in query tool (pgAdmin4)
  In-Reply-To: <CA+OCxoy0ZVietUm3piNLjApyUwnqZBUGSUPq_ct=Mfh6WQn=DA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox