public inbox for [email protected]help / color / mirror / Atom feed
[pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed 4+ messages / 2 participants [nested] [flat]
* [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed @ 2019-01-18 10:58 Aditya Toshniwal <[email protected]> 2019-01-24 14:04 ` Re: [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed Dave Page <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Aditya Toshniwal @ 2019-01-18 10:58 UTC (permalink / raw) To: pgadmin-hackers Hi Hackers, Attached is the patch to fix correct the buttons for json/jsonb type column data editing. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" Attachments: [application/octet-stream] RM3891.patch (1.4K, 3-RM3891.patch) download | inline diff: diff --git a/web/pgadmin/preferences/static/js/preferences.js b/web/pgadmin/preferences/static/js/preferences.js index 88a50bd1..058a9d07 100644 --- a/web/pgadmin/preferences/static/js/preferences.js +++ b/web/pgadmin/preferences/static/js/preferences.js @@ -375,9 +375,9 @@ define('pgadmin.preferences', [ dialogContentCleanup(); $container.append( - '<div class=\'pg-el-3 preferences_tree aciTree\'></div>' + '<div class=\'pg-el-md-3 preferences_tree aciTree\'></div>' ).append( - '<div class=\'pg-el-9 preferences_content\'>' + + '<div class=\'pg-el-md-9 preferences_content\'>' + gettext('Category is not selected.') + '</div>' ); diff --git a/web/pgadmin/static/js/slickgrid/editors.js b/web/pgadmin/static/js/slickgrid/editors.js index 86f460ec..18bba9e9 100644 --- a/web/pgadmin/static/js/slickgrid/editors.js +++ b/web/pgadmin/static/js/slickgrid/editors.js @@ -307,8 +307,8 @@ $input = getTextArea().appendTo($wrapper); $buttons = getButtons(true).appendTo($wrapper); - $buttons.find('button:first').on('click', this.save); - $buttons.find('button:last').on('click', this.cancel); + $buttons.find('button:first').on('click', this.cancel); + $buttons.find('button:last').on('click', this.save); $input.on('keydown', this.handleKeyDown); scope.position(args.position); ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed 2019-01-18 10:58 [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed Aditya Toshniwal <[email protected]> @ 2019-01-24 14:04 ` Dave Page <[email protected]> 2019-01-24 14:09 ` Re: [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed Aditya Toshniwal <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Dave Page @ 2019-01-24 14:04 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers Could you rebase this please? Thanks. On Fri, Jan 18, 2019 at 10:58 AM Aditya Toshniwal <[email protected]> wrote: > > Hi Hackers, > > Attached is the patch to fix correct the buttons for json/jsonb type column data editing. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed 2019-01-18 10:58 [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed Aditya Toshniwal <[email protected]> 2019-01-24 14:04 ` Re: [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed Dave Page <[email protected]> @ 2019-01-24 14:09 ` Aditya Toshniwal <[email protected]> 2019-01-24 14:11 ` Re: [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed Dave Page <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Aditya Toshniwal @ 2019-01-24 14:09 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: pgadmin-hackers Hi Dave, This patch is already committed and resolved. https://redmine.postgresql.org/issues/3891 <https://redmine.postgresql.org/issues/3891; On Thu, Jan 24, 2019 at 7:34 PM Dave Page <[email protected]> wrote: > Could you rebase this please? > > Thanks. > > On Fri, Jan 18, 2019 at 10:58 AM Aditya Toshniwal > <[email protected]> wrote: > > > > Hi Hackers, > > > > Attached is the patch to fix correct the buttons for json/jsonb type > column data editing. > > > > Kindly review. > > > > -- > > Thanks and Regards, > > Aditya Toshniwal > > Software Engineer | EnterpriseDB Software Solutions | Pune > > "Don't Complain about Heat, Plant a tree" > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed 2019-01-18 10:58 [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed Aditya Toshniwal <[email protected]> 2019-01-24 14:04 ` Re: [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed Dave Page <[email protected]> 2019-01-24 14:09 ` Re: [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed Aditya Toshniwal <[email protected]> @ 2019-01-24 14:11 ` Dave Page <[email protected]> 0 siblings, 0 replies; 4+ messages in thread From: Dave Page @ 2019-01-24 14:11 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers On Thu, Jan 24, 2019 at 2:09 PM Aditya Toshniwal <[email protected]> wrote: > > Hi Dave, > > This patch is already committed and resolved. https://redmine.postgresql.org/issues/3891 Oh, OK - I don't have a message in-thread saying that :-( > On Thu, Jan 24, 2019 at 7:34 PM Dave Page <[email protected]> wrote: >> >> Could you rebase this please? >> >> Thanks. >> >> On Fri, Jan 18, 2019 at 10:58 AM Aditya Toshniwal >> <[email protected]> wrote: >> > >> > Hi Hackers, >> > >> > Attached is the patch to fix correct the buttons for json/jsonb type column data editing. >> > >> > Kindly review. >> > >> > -- >> > Thanks and Regards, >> > Aditya Toshniwal >> > Software Engineer | EnterpriseDB Software Solutions | Pune >> > "Don't Complain about Heat, Plant a tree" >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company > > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2019-01-24 14:11 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2019-01-18 10:58 [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed Aditya Toshniwal <[email protected]> 2019-01-24 14:04 ` Dave Page <[email protected]> 2019-01-24 14:09 ` Aditya Toshniwal <[email protected]> 2019-01-24 14:11 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox