public inbox for [email protected]  
help / color / mirror / Atom feed
[pgAdmin4][Patch]: CanDrop option is missing for newly created database
2+ messages / 2 participants
[nested] [flat]

* [pgAdmin4][Patch]: CanDrop option is missing for newly created database
@ 2016-07-12 07:37  Surinder Kumar <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Surinder Kumar @ 2016-07-12 07:37 UTC (permalink / raw)
  To: pgadmin-hackers

Hi

I found this issue while working on an RM case.

*Solution:*
setting *canDrop* flag to True fix the issue.

Please find attached patch with fix and review.


Thanks,
Surinder Kumar


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [application/octet-stream] canDrop_missing_for_new_created_db.patch (670B, 3-canDrop_missing_for_new_created_db.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/__init__.py
index 1f7fd07..06f3413 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/__init__.py
@@ -499,7 +499,8 @@ class DatabaseView(PGChildNodeView):
                     tablespace=response['default_tablespace'],
                     allowConn=True,
                     canCreate=response['cancreate'],
-                    canDisconn=True
+                    canDisconn=True,
+                    canDrop=True
                 )
             )
 


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgAdmin4][Patch]: CanDrop option is missing for newly created database
@ 2016-07-15 09:14  Dave Page <[email protected]>
  parent: Surinder Kumar <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Dave Page @ 2016-07-15 09:14 UTC (permalink / raw)
  To: Surinder Kumar <[email protected]>; +Cc: pgadmin-hackers

Thanks, applied.

On Tue, Jul 12, 2016 at 8:37 AM, Surinder Kumar
<[email protected]> wrote:
> Hi
>
> I found this issue while working on an RM case.
>
> Solution:
> setting canDrop flag to True fix the issue.
>
> Please find attached patch with fix and review.
>
>
> Thanks,
> Surinder Kumar
>
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2016-07-15 09:14 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-07-12 07:37 [pgAdmin4][Patch]: CanDrop option is missing for newly created database Surinder Kumar <[email protected]>
2016-07-15 09:14 ` Dave Page <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox