public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM#3037] Allow user to disable Gravatar image
Date: Wed, 7 Mar 2018 16:35:41 +0000
Message-ID: <CA+OCxoy2VaBnS61m3i2aOksMS6o7E39kjLsoezLsPh5c00SVKA@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZQDE-HhywR8Ky0v6_nA3TWVhPqB8Fc034+WScckBPs1KA@mail.gmail.com>
References: <CAKKotZQynh9AcUpyVPj0aVDOBjvUH7mYRJb5Cc1=Spzg_LBD_g@mail.gmail.com>
<CA+OCxowXxPpwZPvmGW3iDyjXE_6Na6LKk8XbNwVOKWN8iwobkA@mail.gmail.com>
<CAKKotZQDE-HhywR8Ky0v6_nA3TWVhPqB8Fc034+WScckBPs1KA@mail.gmail.com>
Thanks, applied.
On Wed, Mar 7, 2018 at 3:17 PM, Murtuza Zabuawala <
[email protected]> wrote:
> Hi Dave,
>
> PFA updated patch.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Wed, Mar 7, 2018 at 7:20 PM, Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Mon, Mar 5, 2018 at 8:12 AM, Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> PFA patch to disable Gravatar image in Server mode.
>>>
>>> Requirments & Issues:
>>> - For security reasons.
>>> - For systems which do not have internet access.
>>> - Hangs pgAdmin4 while loading the page if connection has no internet
>>> access (as described in the ticket)
>>>
>>
>> If I run with the Gravatar disabled, then I get the following regression
>> failure:
>>
>> ======================================================================
>> FAIL: runTest (pgadmin.browser.tests.test_login.LoginTestCase)
>> Valid_Credentials
>> ----------------------------------------------------------------------
>> Traceback (most recent call last):
>> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/tests/test_login.py",
>> line 93, in runTest
>> self.assertTrue(self.respdata in response.data.decode('utf8'))
>> AssertionError: False is not true
>>
>> ----------------------------------------------------------------------
>>
>> It's fine when Gravatar is enabled (and the rest of the patch does too).
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (11+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin4][RM#3037] Allow user to disable Gravatar image
In-Reply-To: <CA+OCxoy2VaBnS61m3i2aOksMS6o7E39kjLsoezLsPh5c00SVKA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox