public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Ashesh Vashi <[email protected]>
Cc: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)
Date: Tue, 9 Aug 2016 14:04:45 +0100
Message-ID: <CA+OCxoy8FKgAT2RVw-yctkJcURmLKpk2bBcGqbneP+=F87BtNw@mail.gmail.com> (raw)
In-Reply-To: <CAG7mmowVhXbusQ1ZO879GxNvXR0CoGETM27mgpiUebZzLzmMMQ@mail.gmail.com>
References: <CAKKotZTJY1zV+Edi_oJ3611WJVq4Qi4RXi00Ddzkp6iWJardMA@mail.gmail.com>
<CA+OCxowMGSBwuAVj96y4eQ7FSFOnv943bkJZVzZ=SN8Rb3St3g@mail.gmail.com>
<CAG7mmowVhXbusQ1ZO879GxNvXR0CoGETM27mgpiUebZzLzmMMQ@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
On Tue, Aug 9, 2016 at 2:01 PM, Ashesh Vashi <[email protected]>
wrote:
> On Tue, Aug 9, 2016 at 6:28 PM, Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Tue, Aug 9, 2016 at 8:07 AM, Murtuza Zabuawala
>> <[email protected]> wrote:
>> > Hi,
>> >
>> > PFA patch to fix the issue where message panel was showing incomplete
>> info.
>> > We may still miss some messages from Psycopg2 driver due to limited
>> size of
>> > notices queue.
>> > (RM#1523)
>>
>> A few thoughts on this (mostly based on my discussions with Ashesh):
>>
>> 1) You seem to have removed the poll delay. I assume that is to try to
>> avoid missing messages? Can we re-introduce the delay (to avoid
>> excessive network requests), but collect messages while we're waiting?
>>
> Using thread?
> Start a thread during the timeout?
>
Not necessarily. If we want a 2 second polling delay, we could just sleep
for 0.5 secs, collect messages, sleep for 0.5 sec, collect messages,
<repeat...> return to client.
>
>> 2) If I run VACUUM, whilst I see messages as I should now, there is no
>> query time summary as there is for a query that returns data.
>>
>
>> 3) Can we incrementally display messages? e.g. each time we poll, we
>> add the new messages to the messages div, and scroll to the end
>> automatically?
>
> Yeah - that's a good idea.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com/;
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi;
>
>>
>
>
>
>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list ([email protected])
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (14+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)
In-Reply-To: <CA+OCxoy8FKgAT2RVw-yctkJcURmLKpk2bBcGqbneP+=F87BtNw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox