public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: Nikhil Mohite <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Patch for SonarQube code scan fixes.
Date: Tue, 8 Sep 2020 12:56:19 +0100
Message-ID: <CA+OCxoyDvD4wsao0=bCZQHFh826Q1qgMv3g5T7o36oyGEUZ25Q@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_mFY1t0cC8pK3aBSzScW9C16xvLFsU1HczYaoezAypfOQ@mail.gmail.com>
References: <CAOBg0AP6zw+5M2Ux8u9igedVHKUOrPwEdH=+pwmCgfki=o=a=A@mail.gmail.com>
<CAM9w-_mgC6O1Pb36F_BiG8mt5_5BRAT1XCO0etkLCO+Ux78o8A@mail.gmail.com>
<CA+OCxozngZBtnsQywQJ+rnUp-scXmYmzCeFoxQ9oZtvY5MxW4g@mail.gmail.com>
<CAM9w-_mFY1t0cC8pK3aBSzScW9C16xvLFsU1HczYaoezAypfOQ@mail.gmail.com>
On Tue, Sep 8, 2020 at 11:40 AM Aditya Toshniwal <
[email protected]> wrote:
> Hi Dave,
>
> On Tue, Sep 8, 2020 at 3:53 PM Dave Page <[email protected]> wrote:
>
>>
>> On Tue, Sep 8, 2020 at 11:01 AM Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> sqlautocomplete code is mostly inherited from the pgcli project.
>>> Changing it might create trouble in updating the code with new versions.
>>>
>>
>> Send a patch upstream :-)
>>
> I remember Akshay had fixed all the PEP8 issues in pgcli and sent the
> patch. But it was rejected by the pgcli author. :/
>
Doesn't mean this one will be though - we can at least try.
>
>>
>>>
>>> On Tue, Sep 8, 2020 at 2:59 PM Nikhil Mohite <
>>> [email protected]> wrote:
>>>
>>>> Hi Team,
>>>>
>>>> I have fixed some code smell issues in the SonarQube scan, PFA patch.
>>>> Details as follows:
>>>>
>>>> 1. psycopg2/connection:
>>>>
>>>> - Refactor this function to reduce its Cognitive Complexity from 32
>>>> to the 15 allowed.
>>>> - Refactor this function to reduce its Cognitive Complexity from 17
>>>> to the 15 allowed.
>>>>
>>>> 2. psycopg2/server_manager:
>>>>
>>>> - Refactor this function to reduce its Cognitive Complexity from 20
>>>> to the 15 allowed.
>>>> - Refactor this function to reduce its Cognitive Complexity from 33
>>>> to the 15 allowed.
>>>> - Refactor this function to reduce its Cognitive Complexity from 26
>>>> to the 15 allowed.
>>>>
>>>> 3. sqlautocomplete/parseutils:
>>>>
>>>> - Refactor this function to reduce its Cognitive Complexity from 23
>>>> to the 15 allowed.
>>>>
>>>>
>>>>
>>>> --
>>>> *Thanks & Regards,*
>>>> *Nikhil Mohite*
>>>> *Software Engineer.*
>>>> *EDB Postgres* <https://www.enterprisedb.com/;
>>>> *Mob.No: +91-7798364578.*
>>>>
>>>
>>>
>>> --
>>> Thanks,
>>> Aditya Toshniwal
>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>>> <http://edbpostgres.com;
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EDB: http://www.enterprisedb.com
>>
>>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com;
> "Don't Complain about Heat, Plant a TREE"
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EDB: http://www.enterprisedb.com
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Patch for SonarQube code scan fixes.
In-Reply-To: <CA+OCxoyDvD4wsao0=bCZQHFh826Q1qgMv3g5T7o36oyGEUZ25Q@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox