public inbox for [email protected]  

help / color / mirror / Atom feed
From: Akshay Joshi <[email protected]>
To: Nikhil Mohite <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Patch for SonarQube code scan fixes.
Date: Wed, 9 Sep 2020 11:28:05 +0530
Message-ID: <CANxoLDeMg5nqxnKM_H3j3cVLGFJEzB4Dtrm6rqUBDLA4PJQ+Bg@mail.gmail.com> (raw)
In-Reply-To: <CAOBg0AP6zw+5M2Ux8u9igedVHKUOrPwEdH=+pwmCgfki=o=a=A@mail.gmail.com>
References: <CAOBg0AP6zw+5M2Ux8u9igedVHKUOrPwEdH=+pwmCgfki=o=a=A@mail.gmail.com>

Thanks, patch applied. I haven't committed changes for
"sqlautocomplete/parseutils", as Dave suggested send the patch to pgcli.

On Tue, Sep 8, 2020 at 2:59 PM Nikhil Mohite <[email protected]>
wrote:

> Hi Team,
>
> I have fixed some code smell issues in the SonarQube scan, PFA patch.
> Details as follows:
>
> 1. psycopg2/connection:
>
>    - Refactor this function to reduce its Cognitive Complexity from 32 to
>    the 15 allowed.
>    - Refactor this function to reduce its Cognitive Complexity from 17 to
>    the 15 allowed.
>
> 2. psycopg2/server_manager:
>
>    - Refactor this function to reduce its Cognitive Complexity from 20 to
>    the 15 allowed.
>    - Refactor this function to reduce its Cognitive Complexity from 33 to
>    the 15 allowed.
>    - Refactor this function to reduce its Cognitive Complexity from 26 to
>    the 15 allowed.
>
> 3. sqlautocomplete/parseutils:
>
>    - Refactor this function to reduce its Cognitive Complexity from 23 to
>    the 15 allowed.
>
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* <https://www.enterprisedb.com/;
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*


view thread (6+ messages)

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Patch for SonarQube code scan fixes.
  In-Reply-To: <CANxoLDeMg5nqxnKM_H3j3cVLGFJEzB4Dtrm6rqUBDLA4PJQ+Bg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox