public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in the Select File window when opening a saved query
Date: Thu, 21 Jun 2018 19:27:06 +0100
Message-ID: <CA+OCxoyLdSqBw1AiX+2A-QbOKfiSxmPh9bJ2yZwLdT37K+AkKg@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDeEccXUAjFhEpzrywqYpLoOB+tzgRqr4ROA_1A4Nyhzgg@mail.gmail.com>
References: <CANxoLDe9Yh58zEP8=ZQOAwk=RszUrBwYqxXiR+wmd4pP8i5ZJg@mail.gmail.com>
<CA+OCxoxkuv7863HAB10fxUeJUezDBSNW4awos6-eDgK9-_UZkw@mail.gmail.com>
<CANxoLDeEccXUAjFhEpzrywqYpLoOB+tzgRqr4ROA_1A4Nyhzgg@mail.gmail.com>
Hi
On Thu, Jun 21, 2018 at 6:27 AM, Akshay Joshi <[email protected]
> wrote:
>
>
> On Thu, Jun 21, 2018 at 6:20 AM, Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Wed, Jun 20, 2018 at 3:13 PM, Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch for Feature #3273 Add ability to sort in the
>>> Select File window when opening a saved query.
>>>
>>> I haven't seen any refactoring possibility, patch contains feature test
>>> with *time.sleep(0.05). *I have spend lot of time to not introduce
>>> "time.sleep()" and tried couple of different ways of WebDriveWait, but
>>> didn't get success.
>>>
>>> Please review it.
>>>
>>
>> I get the following running the feature tests:
>>
>> invalid syntax (xss_checks_file_manager_test.py, line 60)
>>
>> make: *** [check-feature] Error 1
>>
>> Fixed.
>
>
>> Also; should that file be renamed now, to reflect that it tests more than
>> just XSS?
>>
>
> Done. Attached is the modified patch.
>
This seems to work for the most part, however, when sorting on the Modified
column, it is sorting alphabetically, not by date. This doesn't seem like
it's what users would expect.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (8+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in the Select File window when opening a saved query
In-Reply-To: <CA+OCxoyLdSqBw1AiX+2A-QbOKfiSxmPh9bJ2yZwLdT37K+AkKg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox