public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Nagesh Dhope <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: RE-SQL test patch for extension node
Date: Tue, 9 Jul 2019 13:23:35 +0100
Message-ID: <CA+OCxoyPYtzUh39BGh9xw=Gmi7WVdAb_BujrpoMUJ7LhiTNmQg@mail.gmail.com> (raw)
In-Reply-To: <CAA3zdZp72vQV-B5SEcU7YK93pA6jJGYs8+BgPoxux4bG=wL3Og@mail.gmail.com>
References: <CAA3zdZo_bNe=140wpy4tLkR3qHWY9xL--ymf=yKaab6-Z98OMw@mail.gmail.com>
<CA+OCxoy2tf9WXu7_E35=Pa3vMCaBegVMQGWNcpgQxS93_TJeeQ@mail.gmail.com>
<CAA3zdZpY=KkTm+EibfDUUeCJY1pRNCz_gEVYXmHThRb_04b6TQ@mail.gmail.com>
<CA+OCxozbvdLy=f34x6tPKq7Yagk3786GQZ3sdPtQPedt4z3a1g@mail.gmail.com>
<CAA3zdZp72vQV-B5SEcU7YK93pA6jJGYs8+BgPoxux4bG=wL3Og@mail.gmail.com>
Thanks, applied!
On Tue, Jul 9, 2019 at 1:09 PM Nagesh Dhope <[email protected]>
wrote:
> Hi Dave,
>
> On Tue, Jul 9, 2019 at 4:54 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> I have a sneaking suspicion that the work Akshay and Khushboo have been
>> doing might have broken this :-(
>>
>
> Yup, earlier we were able to create a schema if not exists while running *alter
> *test cases. As this capability is remove alter test case for extension
> was failing.
> I have fixed the test case, PFA updated patch.
>
>
>> Create Extension with all options..............OK
>> ... 2019-07-09 12:22:55,268: ERROR flask.app: Failed to execute query
>> (execute_dict) for the server #5- DB:test_db_d08e5 (Query-id: 1400245):
>> Error Message:ERROR: schema "test_extension_schema" does not exist
>>
>> Alter Extension version..............FAIL
>> Traceback (most recent call last):
>> File
>> "/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line
>> 230, in execute_test_case
>> self.assertEquals(response.status_code, 200)
>> File
>> "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py",
>> line 1338, in deprecated_func
>> return original_func(*args, **kwargs)
>> File
>> "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py",
>> line 839, in assertEqual
>> assertion_func(first, second, msg=msg)
>> File
>> "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py",
>> line 832, in _baseAssertEqual
>> raise self.failureException(msg)
>> AssertionError: 500 != 200
>>
>>
>> On Tue, Jul 9, 2019 at 6:16 AM Nagesh Dhope <
>> [email protected]> wrote:
>>
>>> Hi Dave,
>>>
>>> Please find updated patch with *sslinfo.*
>>>
>>> On Mon, Jul 8, 2019 at 2:03 PM Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>> On Fri, Jul 5, 2019 at 5:16 PM Nagesh Dhope <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Hackers,
>>>>> Please review attached patch for RE-SQL test cases for *extension*
>>>>> node.
>>>>>
>>>>
>>>> Unfortunately this fails on PostgreSQL 12 as the deprecated timetravel
>>>> contrib module has finally been removed.
>>>>
>>>> Perhaps use sslinfo? That seems less likely to go away anytime soon.
>>>>
>>>> Thanks.
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (7+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: RE-SQL test patch for extension node
In-Reply-To: <CA+OCxoyPYtzUh39BGh9xw=Gmi7WVdAb_BujrpoMUJ7LhiTNmQg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox