public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Surinder Kumar <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: Slickgrid loading issue in Query tool
Date: Mon, 19 Sep 2016 17:09:19 +0100
Message-ID: <CA+OCxoyYCburKQM=5WcUKA1NdiJUSLuTvESS1xr+s+d5mKjgBA@mail.gmail.com> (raw)
In-Reply-To: <CAM5-9D8fkGNhktgspPc2wS78EEnxtzgCaQsaXADcn0oV=dLhoA@mail.gmail.com>
References: <CAM5-9D8fkGNhktgspPc2wS78EEnxtzgCaQsaXADcn0oV=dLhoA@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Thanks, applied.

On Mon, Sep 19, 2016 at 2:58 PM, Surinder Kumar
<[email protected]> wrote:
> Hi
>
> Issue:
> Slick-grid libraries loads when an instance of query tool is opened. But
> sometimes it throws exception "jQuery is not defined" and it doesn't opens
> up.
>
> Solution:
> As per my understanding, In datagrid/index.html file, we set the order of
> loading libraries such as
> require(['jquery', 'pgadmin', 'pgadmin.sqleditor'])
> but it still loads pgadmin.sqleditor.js file before jQuery for unknown
> reason.
>
> To fix this, we load pgadmin.sqleditor.js file using require([],
> function(){}) module loader which ensures that the code within function(){}
> will be executed when pgadmin.sqleditor.js is loaded.
>
> Please find attache patch.
> This issue is fixed by Ashesh Vashi.
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch]: Slickgrid loading issue in Query tool
  In-Reply-To: <CA+OCxoyYCburKQM=5WcUKA1NdiJUSLuTvESS1xr+s+d5mKjgBA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox