public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM#3139] Create proper template path if Windows
Date: Mon, 12 Mar 2018 20:41:27 -0400
Message-ID: <CA+OCxoyZpBo4M9LqGF=3p6sQLZ4xZfgFB=+1sRh1dQN7XwOoug@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZSDVNp73-NJ3WFJi=SBNNQ7Mu0SjfLmOcLcGTdFFxbmow@mail.gmail.com>
References: <CAKKotZSDVNp73-NJ3WFJi=SBNNQ7Mu0SjfLmOcLcGTdFFxbmow@mail.gmail.com>

Hi

On Mon, Mar 12, 2018 at 10:15 AM, Murtuza Zabuawala <
[email protected]> wrote:

> Hi,
>
> PFA patch to correct the template path generation logic incase of Windows
> system.
>

Seems like it would be better to fix it the other way round to me - e.g.
update the template loader to use os.path.join.

Any reason not to do that?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

view thread (8+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][RM#3139] Create proper template path if Windows
  In-Reply-To: <CA+OCxoyZpBo4M9LqGF=3p6sQLZ4xZfgFB=+1sRh1dQN7XwOoug@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox