public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch] - RM #3309 - Backup does not work with --format=d
Date: Mon, 25 Jun 2018 15:37:29 +0100
Message-ID: <CA+OCxoyap_9ZiSDVXYpumi-e9w0tyxXJUMvUFwV9Twm2F5K2wA@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELdWjX3czSKSPEq_8ynq8e-Sx+wPhTtCESLvq-iC0OoFKg@mail.gmail.com>
References: <CAFOhELcKP1eRWNwtT3=UVoKPiwR2Pt6LhS+=C0D8vCs1AiK3GQ@mail.gmail.com>
<CA+OCxoyCFZgqa5qKxatwVp9kQ8PO7_EXTWZTZgtNKDwRv=cTyg@mail.gmail.com>
<CAFOhELdWjX3czSKSPEq_8ynq8e-Sx+wPhTtCESLvq-iC0OoFKg@mail.gmail.com>
On Mon, Jun 25, 2018 at 3:33 PM, Khushboo Vashi <
[email protected]> wrote:
>
>
> On Mon, 25 Jun 2018, 19:47 Dave Page, <[email protected]> wrote:
>
>> Hi
>>
>> On Mon, Jun 25, 2018 at 1:23 PM, Khushboo Vashi <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch for RM #3309 - Backup does not work with
>>> --format=d.
>>>
>>> Fixes in the patch :
>>>
>>> 1. Format = directory fix for Backup and Restore utilities
>>> 2. Test cases for format = directory
>>> 2. File manager fix - The selected directory was not properly populated
>>> in the text box
>>>
>>
>> The patch disables the file picker button if you select Directory format.
>> This seems like poor behaviour; I think we need to modify the dialogue to
>> allow a directory to be selected.
>>
>>
> In the directory format, which ever the folder name given, that will be
> created by pg_dump, so I have disabled it.
>
Sure, but I can't even browse to the location I want to put it now - I have
to manually type in the path. We just need to allow selection of the
directory that will contain the directory.
> 3. Refactoring of File manager JS file
>>>
>>
>> That's somewhat more readable. Can we add tests?
>>
> Will look into it.
>
Thanks.
>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (8+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin4][Patch] - RM #3309 - Backup does not work with --format=d
In-Reply-To: <CA+OCxoyap_9ZiSDVXYpumi-e9w0tyxXJUMvUFwV9Twm2F5K2wA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox