public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Harshal Dhumal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: pgAdmin 4 commit: Improve handling of nulls and default values in the d
Date: Fri, 12 May 2017 12:30:52 +0100
Message-ID: <CA+OCxoydonNXGzXe5LrzGG+XSisEcYDhOTENe0F3hd5xjmERww@mail.gmail.com> (raw)
In-Reply-To: <CAFiP3vz0Gxnj9oexauxkVttZx5_su2PqEXnqN1OPKTgB_mOT-g@mail.gmail.com>
References: <[email protected]>
<CAFiP3vz0Gxnj9oexauxkVttZx5_su2PqEXnqN1OPKTgB_mOT-g@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
On Fri, May 12, 2017 at 12:19 PM, Harshal Dhumal <
[email protected]> wrote:
> Hi,
>
> Below code snippet from above commit assumes that we have to disable last
> row after saving.
>
> @@ -2320,6
> <https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=blob;f=web/pgadmin/tools/sqleditor/templates/sql...;
> +2340,10
> <https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=blob;f=web/pgadmin/tools/sqleditor/templates/sql...;
> @@ define(
> grid.setSelectedRows([]);
> }
>
> + // Add last row(new row) to keep track of it
> + if (is_added) {
> + self.rows_to_disable.push(grid.getDataLength()-1);
> + }
>
> However this is not the case all the time
>
> For e.g
> Table has some data already and If user adds new row (do not save) and
> then copy past few exiting rows (at this point newly added row no longer
> remains at last position). And after saving it disable last row which is
> not the newly added row.
>
Hmm, good point. Can you/Surinder work up a fix for that in time for the
release please?
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: pgAdmin 4 commit: Improve handling of nulls and default values in the d
In-Reply-To: <CA+OCxoydonNXGzXe5LrzGG+XSisEcYDhOTENe0F3hd5xjmERww@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox