public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Surinder Kumar <[email protected]>
Cc: Harshal Dhumal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: pgAdmin 4 commit: Improve handling of nulls and default values in the d
Date: Fri, 12 May 2017 16:49:04 +0100
Message-ID: <CA+OCxozd+WfJYuupw=8j3VJMNPYrOGEDg9hgw_UY8dVtaCfWJQ@mail.gmail.com> (raw)
In-Reply-To: <CAM5-9D9CHN7BRcaL1-qCSJ7859Yh2PE93-mJMGCi7Z-QMZ2yVA@mail.gmail.com>
References: <[email protected]>
<CAFiP3vz0Gxnj9oexauxkVttZx5_su2PqEXnqN1OPKTgB_mOT-g@mail.gmail.com>
<CA+OCxoydonNXGzXe5LrzGG+XSisEcYDhOTENe0F3hd5xjmERww@mail.gmail.com>
<CAM5-9D8X_YDaj15VyM-YN_37Bgg1LASk=-3TmZe3Dwzd8-bdcQ@mail.gmail.com>
<CAM5-9D9CHN7BRcaL1-qCSJ7859Yh2PE93-mJMGCi7Z-QMZ2yVA@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi
On Fri, May 12, 2017 at 3:20 PM, Surinder Kumar <
[email protected]> wrote:
> Hi Dave,
>
> Please find attached patch and review.
>
Thanks, committed.
>
> Also, I found an issue <https://redmine.postgresql.org/issues/2399; which
> logged and will work on it.
>
Yes, I also saw that, though I found the colour was lost on paste, not
save. I also found another issue -
https://redmine.postgresql.org/issues/2400. Can you fix that too please?
Thanks.
>
> On Fri, May 12, 2017 at 5:19 PM, Surinder Kumar <
> [email protected]> wrote:
>
>> On Fri, May 12, 2017 at 5:00 PM, Dave Page <[email protected]> wrote:
>>
>>>
>>>
>>> On Fri, May 12, 2017 at 12:19 PM, Harshal Dhumal <
>>> [email protected]> wrote:
>>>
>>>> Hi,
>>>>
>>>> Below code snippet from above commit assumes that we have to disable
>>>> last row after saving.
>>>>
>>>> @@ -2320,6
>>>> <https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=blob;f=web/pgadmin/tools/sqleditor/templates/sql...;
>>>> +2340,10
>>>> <https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=blob;f=web/pgadmin/tools/sqleditor/templates/sql...;
>>>> @@ define(
>>>> grid.setSelectedRows([]);
>>>> }
>>>>
>>>> + // Add last row(new row) to keep track of it
>>>> + if (is_added) {
>>>> + self.rows_to_disable.push(grid.getDat
>>>> aLength()-1);
>>>> + }
>>>>
>>>> However this is not the case all the time
>>>>
>>>> For e.g
>>>> Table has some data already and If user adds new row (do not save) and
>>>> then copy past few exiting rows (at this point newly added row no longer
>>>> remains at last position). And after saving it disable last row which is
>>>> not the newly added row.
>>>>
>>>
>>> Hmm, good point. Can you/Surinder work up a fix for that in time for the
>>> release please?
>>>
>> Sure Dave, I am working on it.
>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (6+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: pgAdmin 4 commit: Improve handling of nulls and default values in the d
In-Reply-To: <CA+OCxozd+WfJYuupw=8j3VJMNPYrOGEDg9hgw_UY8dVtaCfWJQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox