public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Surinder Kumar <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Re: [pgAdmin4][Patch]: RM1683 - Reverse engineered SQL for function ALTERs/ACLs is incorrect with OUT parameters
Date: Mon, 12 Sep 2016 15:21:18 +0100
Message-ID: <CA+OCxoyhTn=Ax_bbEmm2xwsDD8dddz-9_cXnmMMcArOr+G=ntA@mail.gmail.com> (raw)
In-Reply-To: <CAM5-9D_JSnaLOLSOAqZA=9wOXtdXyVt2mVdNVVgQo_T2oTayxg@mail.gmail.com>
References: <CAM5-9D_oZ22CaNptwtFMKR-2aEjQDwnr6zeD38sgHK4FW6K3pA@mail.gmail.com>
	<CAM5-9D_mXq9y15EysJwCsk5wsTXtr+trcNv4upzMKTp3ruSrGw@mail.gmail.com>
	<CAM5-9D_JSnaLOLSOAqZA=9wOXtdXyVt2mVdNVVgQo_T2oTayxg@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Thanks, applied.

On Mon, Sep 12, 2016 at 11:57 AM, Surinder Kumar
<[email protected]> wrote:
> Hi
>
> I forgot to remove a line args_without_name += ', ' from the code in
> previous patch, thus it adds extra commas into the function arguments in
> case of procedures only.
> It is now fixed.
> Please find updated v2 patch and review.
>
>
> On Mon, Sep 12, 2016 at 3:54 PM, Surinder Kumar
> <[email protected]> wrote:
>>
>> This patch doesn't fix the issue in Procedure node. I will send updated
>> patch.
>>
>> On Mon, Sep 12, 2016 at 3:12 PM, Surinder Kumar
>> <[email protected]> wrote:
>>>
>>> Hi,
>>>
>>> Please find attached patch with fix.
>>> Changes:
>>> 1) Take a list of "function argument types", create a string separated by
>>> comma(removing trailing comma).
>>> 2) Function arguments in ALTER and GRANT not necessarily to have argument
>>> mode, name, they are optional. Only type is required.
>>> Now GRANT statement is represented as
>>>
>>> GRANT EXECUTE ON FUNCTION test_schema.test_func(integer, integer,
>>> integer) TO postgres as in pgadmin3.
>>>
>>>
>>> Please review.
>>
>>
>
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Re: [pgAdmin4][Patch]: RM1683 - Reverse engineered SQL for function ALTERs/ACLs is incorrect with OUT parameters
  In-Reply-To: <CA+OCxoyhTn=Ax_bbEmm2xwsDD8dddz-9_cXnmMMcArOr+G=ntA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox