public inbox for [email protected]  

help / color / mirror / Atom feed

From: Surinder Kumar <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: RM1683 - Reverse engineered SQL for function ALTERs/ACLs is incorrect with OUT parameters
Date: Mon, 12 Sep 2016 15:54:10 +0530
Message-ID: <CAM5-9D_mXq9y15EysJwCsk5wsTXtr+trcNv4upzMKTp3ruSrGw@mail.gmail.com> (raw)
In-Reply-To: <CAM5-9D_oZ22CaNptwtFMKR-2aEjQDwnr6zeD38sgHK4FW6K3pA@mail.gmail.com>
References: <CAM5-9D_oZ22CaNptwtFMKR-2aEjQDwnr6zeD38sgHK4FW6K3pA@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

This patch doesn't fix the issue in Procedure node. I will send updated
patch.

On Mon, Sep 12, 2016 at 3:12 PM, Surinder Kumar <
[email protected]> wrote:

> Hi,
>
> Please find attached patch with fix.
> *Changes:*
> 1) Take a list of "function argument types", create a string separated by
> comma(removing trailing comma).
> 2) Function arguments in ALTER and GRANT not necessarily to have *argument
> mode, name, *they are optional. Only type is required.
> Now GRANT statement is represented as
>
> *GRANT EXECUTE ON FUNCTION test_schema.test_func(integer, integer,
> integer) TO postgres *as in pgadmin3.
>
>
> Please review.
>

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin4][Patch]: RM1683 - Reverse engineered SQL for function ALTERs/ACLs is incorrect with OUT parameters
  In-Reply-To: <CAM5-9D_mXq9y15EysJwCsk5wsTXtr+trcNv4upzMKTp3ruSrGw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox