public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch] - RM 3836 VACUUM FULL FREEZE ANALYZE VERBOSE syntax error on PostgreSQL 11
Date: Thu, 10 Jan 2019 15:31:14 +0530
Message-ID: <CA+OCxoykjSX-xNffxOOhyqKNXheUbuhJ945j_im-epVAB-Uygg@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDdYep1dPq1Jni6zsb6eOnSOdBH3pJ1wNU-yLoYzEpaD1g@mail.gmail.com>
References: <CANxoLDfBh-SmU=44vLEMz1_jxGDTWWS_OQOfRpagDEHwxDD8qw@mail.gmail.com>
<CA+OCxowGj-P2PkZdw443WdGmCP4yH6GKiCUuQ2LSr+GR2NEJfg@mail.gmail.com>
<CANxoLDdYep1dPq1Jni6zsb6eOnSOdBH3pJ1wNU-yLoYzEpaD1g@mail.gmail.com>
Thanks - applied!
On Thu, Jan 10, 2019 at 12:48 PM Akshay Joshi <[email protected]>
wrote:
> Hi
>
> Attached is the modified patch. I have fixed the similar code for Backup
> and Restore as well along with this patch.
>
> On Thu, Jan 10, 2019 at 12:26 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Wed, Jan 9, 2019 at 6:46 PM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to fix RM #3836 VACUUM FULL FREEZE ANALYZE VERBOSE
>>> syntax error on PostgreSQL 11. Order of commands has been changed in
>>> PostgreSQL 11 "https://github.com/postgres/postgres
>>> /commit/921059bd66c7fb1230c705d3b1a65940800c4cbb"
>>>
>>> Please review it.
>>>
>>
>> I tried to test this, and got what looks like the same issue that we
>> looked at the other day with Import/Export. Can you look at it please?
>>
>> 2019-01-10 12:25:02,044: INFO werkzeug: 127.0.0.1 - - [10/Jan/2019
>> 12:25:02] "POST /maintenance/job/2/12669 HTTP/1.1" 500 -
>> 2019-01-10 12:25:02,051: ERROR werkzeug: Error on request:
>> Traceback (most recent call last):
>> File
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/werkzeug/serving.py",
>> line 270, in run_wsgi
>> execute(self.server.app)
>> File
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/werkzeug/serving.py",
>> line 258, in execute
>> application_iter = app(environ, start_response)
>> File
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py",
>> line 1997, in __call__
>> return self.wsgi_app(environ, start_response)
>> File
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py",
>> line 1985, in wsgi_app
>> response = self.handle_exception(e)
>> File
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py",
>> line 1540, in handle_exception
>> reraise(exc_type, exc_value, tb)
>> File
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/_compat.py",
>> line 33, in reraise
>> raise value
>> File
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py",
>> line 1982, in wsgi_app
>> response = self.full_dispatch_request()
>> File
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py",
>> line 1614, in full_dispatch_request
>> rv = self.handle_user_exception(e)
>> File
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py",
>> line 1517, in handle_user_exception
>> reraise(exc_type, exc_value, tb)
>> File
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/_compat.py",
>> line 33, in reraise
>> raise value
>> File
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py",
>> line 1612, in full_dispatch_request
>> rv = self.dispatch_request()
>> File
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py",
>> line 1598, in dispatch_request
>> return self.view_functions[rule.endpoint](**req.view_args)
>> File
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask_login.py",
>> line 792, in decorated_view
>> return func(*args, **kwargs)
>> File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/tools/maintenance/__init__.py", line
>> 179, in create_maintenance_job
>> data = json.loads(data['data'][0], encoding='utf-8')
>> File
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/simplejson/__init__.py",
>> line 535, in loads
>> return cls(encoding=encoding, **kw).decode(s)
>> File
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/simplejson/decoder.py",
>> line 370, in decode
>> obj, end = self.raw_decode(s)
>> File
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/simplejson/decoder.py",
>> line 400, in raw_decode
>> return self.scan_once(s, idx=_w(s, idx).end())
>> simplejson.errors.JSONDecodeError: Expecting property name enclosed in
>> double quotes or '}': line 1 column 2 (char 1)
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (4+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin4][Patch] - RM 3836 VACUUM FULL FREEZE ANALYZE VERBOSE syntax error on PostgreSQL 11
In-Reply-To: <CA+OCxoykjSX-xNffxOOhyqKNXheUbuhJ945j_im-epVAB-Uygg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox